Corrected GIS File Input Shapefile multiple steps + paths with spaces #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem with the GIS File Input step where an error occured if I had two or more steps of this kind with the shapefile input option. Apparently, while reading the DBF associated file, the stream in RandomAccessFile would be corrupted, and the step threw a NumberFormatException for date and numeric fields. I changed the way it reads a DBF file with the XBase class built in Pentaho. I also changed how it converts a field to Long, because XBase inputs Longs as Doubles, and the FeatureConverter threw a format exception.
I also solved a problem with paths that contain spaces as it happened to me on Windows 10 (URL kept the space as %20, so it had to be decoded to work).