Fix failing bsp_pins! invocation with no aliases
#605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no aliases are included in a call of `bsp_pins!`, the resulting `pin_alias!` macro expands to a completely empty macro definition, which is invalid. Add identity "aliases" for each given pin name. This has two benefits. First, it prevents the empty macro case above. And second, it precludes any possibility of collisions between names and aliases, since all names are now checked before resolving aliases. Closes atsamd-rs#599
|
Clever! |
|
@bradleyharden, do you want this to be merged? I think all that's needed is rebasing onto |
|
Yes, I was waiting to hear from @datagrok, but I'm fairly confident it fixes the problem. |
|
This failed because of some strange rustup error, but I can't restart the job? |
|
Sorry for the delay. This does indeed fix the problem on my repo, @bradleyharden! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no aliases are included in a call of
bsp_pins!, the resultingpin_alias!macro expands to a completely empty macro definition, whichis invalid.
Add identity "aliases" for each given pin name. This has two benefits.
First, it prevents the empty macro case above. And second, it precludes
any possibility of collisions between names and aliases, since all names
are now checked before resolving aliases.
Closes #599
Checklist
CHANGELOG.mdfor the BSP or HAL updated