Fix Wio Terminal ButtonController #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boards/wio_terminal/src/buttons.rs
Outdated
Comment on lines
45
to
51
| 11 as ExternalInterruptID, | ||
| 12 as ExternalInterruptID, | ||
| 3 as ExternalInterruptID, | ||
| 4 as ExternalInterruptID, | ||
| 5 as ExternalInterruptID, | ||
| 10 as ExternalInterruptID, | ||
| 7 as ExternalInterruptID, |
There was a problem hiding this comment.
I think I see the problem. The ExternalInterrupt trait is not defined in a reasonable way anymore. This is probably a problem introduced by the migration to gpio::v2. I think I have a way to fix it, so that you can use .id() again. Let me see if I can implement that first, before we resort to manually specifying all the ExternalInterruptIDs
There was a problem hiding this comment.
@bradleyharden That'd be great; thanks. I hope to be back on wio/rust by the end of the week, when I'll take another stab at #628 and can update this too.
pabigot
force-pushed
the
pabigot/20220822a
branch
from
d85eb8b
to
3966fe1
Compare
pabigot
added a commit
to pabigot/atsamd
that referenced
this pull request
Dec 4, 2022
Re-enable the debounce code.
pabigot
force-pushed
the
pabigot/20220822a
branch
from
3966fe1
to
61d3ec2
Compare
pabigot
changed the title
|
Updated now that #641 is in-place. |
Re-enable the debounce code.
pabigot
force-pushed
the
pabigot/20220822a
branch
from
1f3a986
to
82aecac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If debounce isn't enabled pinstate always returns zero, so the code treats every event as a down state.
Fixes #620.