at_c: discussion on renaming atclient_monitor_response_type enums

[JeremyTubongbanua]

Currently, this is our atclient_monitor_response_type enum:

enum atclient_monitor_response_type {
  // the following 4 enums help indicate what type of message was received from the monitor connection and which field
  // of the union to access
  ATCLIENT_MONITOR_MESSAGE_TYPE_NONE,
  ATCLIENT_MONITOR_MESSAGE_TYPE_NOTIFICATION,   // indicates caller to access `notification` from the union
  ATCLIENT_MONITOR_MESSAGE_TYPE_DATA_RESPONSE,  // indicates caller to access `data_response` from the union
  ATCLIENT_MONITOR_MESSAGE_TYPE_ERROR_RESPONSE, // indicates caller to access `error_response` from the union

  // the following 3 enums help indicate what type of error occurred when reading from the monitor connection, you will
  // expect one of these enums along with a non-zero return value from atclient_monitor_read
  ATCLIENT_MONITOR_ERROR_READ, // could be a read timeout or some other error, indicates the caller to access
                               // `error_read` from the union
  ATCLIENT_MONITOR_ERROR_PARSE_NOTIFICATION,
  ATCLIENT_MONITOR_ERROR_DECRYPT_NOTIFICATION,
};

I would like to propose that it be changed to this instead:

enum atclient_monitor_response_type {
  ATCLIENT_MONITOR_RESPONSE_TYPE_NONE,
  ATCLIENT_MONITOR_RESPONSE_TYPE_NOTIFICATION
  ATCLIENT_MONITOR_RESPONSE_TYPE_DATA_RESPONSE
  ATCLIENT_MONITOR_RESPONSE_TYPE_ERROR_RESPONSE
  ATCLIENT_MONITOR_RESPONSE_TYPE_ERROR_READ,
  ATCLIENT_MONITOR_RESPONSE_TYPE_ERROR_PARSE_NOTIFICATION,
  ATCLIENT_MONITOR_RESPONSE_TYPE_ERROR_DECRYPT_NOTIFICATION,
};

Reason for this change is

• maintain our namespacing convention by having ATCLIENT_MONITOR_RESPONSE_ as the prefix.