-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix auto-record on throttle for robothat MM1 controller #1053
Comments
I reviewed the code and it looks like we did not address the robothat controller when we added the code to make the game controllers and web controller cooperate with setting drive mode (user/autosteering/autopilot) and recording mode. So I ported the code from the joystick controller into the robothat controller. That is in branch robothat-auto-record-on-throttle |
Hey @Ezward , It's been a few years now since I added this functionality and I've been out of touch with Donkey Car since about version v3.0.1. So what exactly is still broken that may need my review? It looks like you have already got a patch/fix in place. CC: @peterpanstechland (foo00) |
@wallarug Thanks for commenting. We added code a while back to make the game controllers and web controller cooperate when changing the drive mode and recording mode. We did not address the robothat at that time. This PR #1055 fixes that by porting the code from the game controller to the robothat controller. Basically we need to latch any change that is made by the user so it can overrwrite the incoming state in run_threaded() sometime later. This branch has been tested and shown to fix the issue. |
Original poster reports that is is fixed https://discord.com/channels/662098530411741184/671604048218292233/1034481825202049157 |
Reported by user
fooOO
in discord"Hi, Has anyone using RoboHAT MM1 and donkeycar 4.3.23? As I have configed the myconfig to record with throttle, but seems like it's not triggering the recording.
...
I did follow the instructions to give the right permission and disabled the nvgetty and I could use RC to control the car and in the Jetson nano serial monitor also output correct pwm info, I think it might be caused by something updated in the donkeycar 4.x, as it used to work with donkeycar 3.x.
BTW I have tried by using the start record button on the web console it seems working properly, so I might just stick to this method."
The text was updated successfully, but these errors were encountered: