Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link is not valid encoder.py #1090

Closed
Ahrovan opened this issue Feb 4, 2023 · 6 comments
Closed

link is not valid encoder.py #1090

Ahrovan opened this issue Feb 4, 2023 · 6 comments

Comments

@Ahrovan
Copy link

Ahrovan commented Feb 4, 2023

https://github.com/autorope/donkeycar/blob/main/donkeycar/parts/encoder.py

The microcontroller should be flashed with this sketch (use the Arduino IDE to do that): https://github.com/zlite/donkeycar/tree/master/donkeycar/parts/encoder/encoder

This link not valid. please update link to Arduino sketch (ino file)

@TCIII
Copy link
Contributor

TCIII commented Feb 4, 2023

@Ahrovan,
The Arduino sketches for both the mono and quadrature encoders can be found here now.

You can copy and paste the sketch of your choice into a new Arduino IDE sketch and flash into an Arduino of your choice.
I use the Adafruit Metro Mini with USB connector, but an Arduino Mini will work too as long as it has a USB connector.

TCIII

@Ezward
Copy link
Contributor

Ezward commented Feb 5, 2023

@Ahrovan The older encoder implementation is being deprecated. There is a new branch that implements an encoder->tachometer-odometer-kinematics pipeline for pose estimation, which makes it suitable to use with the path_follow template. That branch has an open pull request #1089 that we hope to merge very soon (maybe this weekend?). The encoder sketches in the branch are compatible with the older encoder sketch, so you can use them with the older version of Donkeycar if you want.

@Ezward
Copy link
Contributor

Ezward commented Feb 11, 2023

@Ahrovan did you give the encoder sketches in the PR at try?

@Ahrovan
Copy link
Author

Ahrovan commented Feb 11, 2023

Next week I will do and reply here

@Ezward
Copy link
Contributor

Ezward commented Feb 21, 2023

@Ahrovan have you been able to try this?

@Ezward
Copy link
Contributor

Ezward commented Feb 27, 2023

Closing as unresponsive.

@Ezward Ezward closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants