Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple vehicle profiles via multiple .ini files #73

Closed
yconst opened this issue Mar 13, 2017 · 5 comments
Closed

Allow multiple vehicle profiles via multiple .ini files #73

yconst opened this issue Mar 13, 2017 · 5 comments

Comments

@yconst
Copy link
Contributor

yconst commented Mar 13, 2017

The vehicle could be passed as an optional parameter when running the script files, otherwise the default (vehicle.ini) would be used.

@wroscoe
Copy link
Collaborator

wroscoe commented Mar 13, 2017

When would you need multiple profiles on a single vehicle? Also, you should join our slack channel to discuss and share your builds. Enter your email here and I'll add you: http://donkeycar.weebly.com/

@yconst
Copy link
Contributor Author

yconst commented Mar 14, 2017

Thanks, I've sent a request.

The case I was facing was that of having two vehicles and changing the SD card between them. One had different servo/motor settings so I believe multiple configs can be helpful in such cases.

But I imagine this could also go another way: Offering different stock configuration files for different vehicle models (e.g. different rc car models) and types (diff steering, normal steering), can open Donkey to a wider audience (e.g. people who already have different models of rc cars/vehicles).

@wroscoe
Copy link
Collaborator

wroscoe commented Mar 14, 2017

This should be done with an optional argument "--config" that can specify a different config file. The diff drive does not yet use config files.

@yconst
Copy link
Contributor Author

yconst commented Mar 21, 2017

I've added --config parsing and a couple of vehicle configs based on the google doc manual in the following commit:
https://github.com/yconst/donkey/commit/5fb192c443eb0b43ea6d37134cb0a800bc263ff8

I did not create a pull request because this commit also includes the changes to start-server.sh, part of another mr. Once that mr is resolved, I'm going to add one for this too.

@yconst
Copy link
Contributor Author

yconst commented Apr 12, 2017

This has been merged to dev. Closing

@yconst yconst closed this as completed Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants