Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In both the DC master and dev branches there is no "test_encoder.py" in the tests folder #924

Closed
TCIII opened this issue Aug 22, 2021 · 2 comments

Comments

@TCIII
Copy link
Contributor

TCIII commented Aug 22, 2021

In the DC "encoder.py" part introduction there is a reference to a "test_encoder.py code in the Donkeycar tests folder.

A review of the DC tests folder in both the master and dev branches found no "test_encoder.py" test.

However a "test_encoder.py" test can be found here: https://github.com/zlite/donkeycar/tree/master/donkeycar/tests

Suggest that either a "test_encoder.py" test be added to both the DC master and dev tests directory or that the "test_encoder.py" code reference be removed from the DC "encoder.py" part introduction until such time that the "test_encoder.py" test is added to both DC branches.

@Ezward
Copy link
Contributor

Ezward commented Sep 22, 2021

We intend to deprecate the old encoder code in favor of tachometer.py and odometer.py in this branch; https://github.com/autorope/donkeycar/tree/921-next-generation-odometer-parts That code does have tests. When that get's integrated into master we can close this issue. I would not otherwise bother addressing this issue.

@Ezward
Copy link
Contributor

Ezward commented Feb 18, 2023

PR #1089 introduces a new encoder based pipeline for encoder->tachometer-odometer-kinematics pose estimation. tachometer.py has it's own test program build into the file's main. The older encoder.py implementation is marked as deprecated, so I am closing this issue.

@Ezward Ezward closed this as completed Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants