Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ROI_CROP_TOP to zero and make sure getting started addresses this #959

Closed
Ezward opened this issue Dec 1, 2021 · 1 comment
Closed

Comments

@Ezward
Copy link
Contributor

Ezward commented Dec 1, 2021

The current default is ROI_CROP_TOP=45 which is generally ok for a standard 1/16 donkey car. However it is almost certainly wrong for any other car. Cropping is critical to success in the real world. I suggest that we revert this to zero and make sure we have good documentation for setting this as part of the getting start process; probably after calibration and before training.

NOTE that the ROI_* configurations are only applied if the string 'CROP' is added to the TRANSFORMATIONS array in the configuration file.

@Ezward
Copy link
Contributor Author

Ezward commented Jan 15, 2022

This is not necessary because ROI_* configurations are only applied if 'CROP' is added to the TRANSFORMATIONS array, so no cropping is applied by default.

@Ezward Ezward closed this as completed Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant