From 75330201a74c68b6b29ef09f7867644130747f85 Mon Sep 17 00:00:00 2001 From: Mark Wubben Date: Mon, 3 Jul 2023 17:11:20 +0200 Subject: [PATCH] Remove workaround for worker.terminate() crashes Looks like the patch is included in all supported Node.js versions. --- lib/fork.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/fork.js b/lib/fork.js index ed5e22907..3366c2125 100644 --- a/lib/fork.js +++ b/lib/fork.js @@ -4,7 +4,6 @@ import {fileURLToPath} from 'node:url'; import {Worker} from 'node:worker_threads'; import Emittery from 'emittery'; -import {pEvent} from 'p-event'; import {controlFlow} from './ipc-flow-control.cjs'; import serializeError from './serialize-error.js'; @@ -35,13 +34,8 @@ const createWorker = (options, execArgv) => { }); postMessage = worker.postMessage.bind(worker); - // Ensure we've seen this event before we terminate the worker thread, as a - // workaround for https://github.com/nodejs/node/issues/38418. - const starting = pEvent(worker, 'message', ({ava}) => ava?.type === 'starting'); - close = async () => { try { - await starting; await worker.terminate(); } finally { // No-op