Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis service controller #235

Open
cc4i opened this issue Aug 23, 2020 · 6 comments
Open

Kinesis service controller #235

cc4i opened this issue Aug 23, 2020 · 6 comments
Labels
kind/new-service Categorizes issue or PR as related to a new service. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. service/kinesis Indicates issues or PRs that are related to kinesis-controller.

Comments

@cc4i
Copy link

cc4i commented Aug 23, 2020

New ACK Service Controller

Support for Amazon Kinesis

List of API resources

List the API resources in order of importance to you:

  1. Stream
@cc4i cc4i added the kind/new-service Categorizes issue or PR as related to a new service. label Aug 23, 2020
@cc4i cc4i changed the title [name] service controller Amazon Kinesis service controller Aug 23, 2020
@jaypipes
Copy link
Collaborator

Keep in mind that ACK only handles control plane operations, not data plane operations, so Kinesis API operations like SubscribeToStream, DeregisterStreamConsumer, PutRecord and PutRecords are not going to be supported.

Some Kinesis API operations that are going to be problematic:

  • IncreaseStreamRetentionPeriod
  • DecreaseStreamRetentionPeriod
  • EnableEnhancedMonitoring
  • DisableEnhancedMonitoring
  • StartStreamEncryption
  • StopStreamEncryption
  • UpdateShardCount

Because they represent mutating operations on just a single attribute of a stream and there isn't a ModifyStream or UpdateStream API call, which means we're going to need to inform the code generator in ACK what all those API operations actually do...

  • MergeShards
  • ListStreamConsumers

Neither of these is congruent with the Kubernetes API and declarative modeling.

So, at least initially, it's only going to be CreateStream and DeleteStream and then followed by the "single attribute mutating operations".

@cc4i
Copy link
Author

cc4i commented Aug 26, 2020

Thanks @jaypipes pointed out operational focus. Just want to confirm will embed inform code into generator to handle these kind of service or not determine yet?

@jaypipes
Copy link
Collaborator

@cc4i we will be enhancing the code generator in ACK to account for these kinds of odd API calls, yes. Already starting to do that with the Elasticache and RDS ACK service controllers, since both of those APIs have a lot of rough edges like this :)

@ack-bot
Copy link
Collaborator

ack-bot commented Aug 27, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-bot ack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 27, 2021
@RedbackThomson
Copy link
Contributor

/lifecycle frozen

@ack-bot ack-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 27, 2021
@RedbackThomson RedbackThomson changed the title Amazon Kinesis service controller Kinesis service controller Apr 29, 2022
@a-hilaly a-hilaly added service/kinesis Indicates issues or PRs that are related to kinesis-controller. and removed Kinesis labels Dec 13, 2022
@jaypipes
Copy link
Collaborator

@cc4i and all other watchers: you can install and use the Kinesis controller for ACK now.

You can install it using the kinesis-chart Helm chart.

Feedback and criticism very much welcomed!
-jay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/new-service Categorizes issue or PR as related to a new service. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. service/kinesis Indicates issues or PRs that are related to kinesis-controller.
Projects
Development

No branches or pull requests

6 participants