Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various issues in scripts #86

Open
viraptor opened this issue Jul 19, 2019 · 0 comments
Open

Various issues in scripts #86

viraptor opened this issue Jul 19, 2019 · 0 comments

Comments

@viraptor
Copy link

I've noticed that shellcheck picks up numerous real issues with the scripts in this repo. For example this is a commit fixing only the issue of local not propagating the return value from assignment (which means the $? checks after it will never fail) viraptor@9d55660
There are a few others as well.

It looks like the scripts could use a cleanup beyond a single PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant