From 4c5f96db7134ce2886543e0aa94787772d4dd49b Mon Sep 17 00:00:00 2001 From: Rico Huijbers Date: Tue, 17 Jan 2023 12:13:21 +0100 Subject: [PATCH] Incorporate some comments --- packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts | 2 +- packages/@aws-cdk-testing/cli-integ/lib/integ-test.ts | 2 -- packages/@aws-cdk-testing/cli-integ/lib/xpmutex.ts | 8 ++++---- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts b/packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts index 9f26ca12b705b..46a19e44bf47b 100644 --- a/packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts +++ b/packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts @@ -24,7 +24,7 @@ async function main() { }) .option('use-source', { descripton: 'Use TypeScript packages from the given source repository (or "auto")', - alias: 'S', + alias: 's', type: 'string', requiresArg: true, }) diff --git a/packages/@aws-cdk-testing/cli-integ/lib/integ-test.ts b/packages/@aws-cdk-testing/cli-integ/lib/integ-test.ts index 731bddd7e2e91..e529591c50d1e 100644 --- a/packages/@aws-cdk-testing/cli-integ/lib/integ-test.ts +++ b/packages/@aws-cdk-testing/cli-integ/lib/integ-test.ts @@ -50,8 +50,6 @@ export function integTest( // jest and prints without a stack trace (if verbose: false). // eslint-disable-next-line no-console console.log(output.buffer().toString()); - // await output.flushTo(process.stderr); - // process.stderr.write(`❌ ${e.toString()}\n`); throw e; } }, timeoutMillis); diff --git a/packages/@aws-cdk-testing/cli-integ/lib/xpmutex.ts b/packages/@aws-cdk-testing/cli-integ/lib/xpmutex.ts index 6780215b5fdc6..4687164a1b5ee 100644 --- a/packages/@aws-cdk-testing/cli-integ/lib/xpmutex.ts +++ b/packages/@aws-cdk-testing/cli-integ/lib/xpmutex.ts @@ -12,7 +12,7 @@ export class XpMutexPool { return XpMutexPool.fromDirectory(path.join(os.tmpdir(), name)); } - private readonly queuedResolvers = new Set<() => void>(); + private readonly waitingResolvers = new Set<() => void>(); private watcher: ReturnType | undefined; private constructor(public readonly directory: string) { @@ -31,7 +31,7 @@ export class XpMutexPool { */ public awaitUnlock(maxWaitMs?: number): Promise { const wait = new Promise(ok => { - this.queuedResolvers.add(async () => { + this.waitingResolvers.add(async () => { await randomSleep(10); ok(); }); @@ -67,10 +67,10 @@ export class XpMutexPool { } private notifyWaiters() { - for (const promise of this.queuedResolvers) { + for (const promise of this.waitingResolvers) { promise(); } - this.queuedResolvers.clear(); + this.waitingResolvers.clear(); } }