From c266fe1815ceef7ee59635aff7598fedee5adf8c Mon Sep 17 00:00:00 2001 From: Lennart Coopmans Date: Thu, 4 Apr 2024 11:03:32 +0200 Subject: [PATCH] Add support for the aws-cn partition when validating notification ARNs. --- packages/aws-cdk/lib/util/validate-notification-arn.ts | 2 +- packages/aws-cdk/test/util/validate-notification-arn.test.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/aws-cdk/lib/util/validate-notification-arn.ts b/packages/aws-cdk/lib/util/validate-notification-arn.ts index 4d1f458a8c3db..647f8e1afdc94 100644 --- a/packages/aws-cdk/lib/util/validate-notification-arn.ts +++ b/packages/aws-cdk/lib/util/validate-notification-arn.ts @@ -2,5 +2,5 @@ * Validate SNS topic arn */ export function validateSnsTopicArn(arn: string): boolean { - return /^arn:aws:sns:[a-z0-9\-]+:[0-9]+:[a-z0-9\-\_]+$/i.test(arn); + return /^arn:(?:aws|aws-cn):sns:[a-z0-9\-]+:[0-9]+:[a-z0-9\-\_]+$/i.test(arn); } diff --git a/packages/aws-cdk/test/util/validate-notification-arn.test.ts b/packages/aws-cdk/test/util/validate-notification-arn.test.ts index d418546eda923..0665828886e2b 100644 --- a/packages/aws-cdk/test/util/validate-notification-arn.test.ts +++ b/packages/aws-cdk/test/util/validate-notification-arn.test.ts @@ -26,5 +26,10 @@ describe('validate sns arns', () => { const arn = 'arn:aws:sns:eu-west-1:123456789876:foo-bar_baz'; expect(validateSnsTopicArn(arn)).toEqual(true); }); + + test('AWS China partition', () => { + const arn = 'arn:aws-cn:sns:cn-northwest-1:123456789876:foo-bar'; + expect(validateSnsTopicArn(arn)).toEqual(true); + }); });