Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECR: support force upon deletion #2765

Closed
thesurlydev opened this issue Jun 6, 2019 · 9 comments
Closed

ECR: support force upon deletion #2765

thesurlydev opened this issue Jun 6, 2019 · 9 comments
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed.

Comments

@thesurlydev
Copy link
Contributor

When deleting an ECR repository using the SDK or CLI there's a force option which will delete the repository regardless if there images in the repository. Please support this option, otherwise users are forced to use a custom resource as a workaround.

For reference, see:

  1. https://docs.aws.amazon.com/cli/latest/reference/ecr/delete-repository.html
  2. https://docs.aws.amazon.com/AmazonECR/latest/APIReference/API_DeleteRepository.html
@thesurlydev thesurlydev added the feature-request A feature should be added or improved. label Jun 6, 2019
@RomainMuller
Copy link
Contributor

This feature is not supported by CloudFormation currently. This means that, if CDK does anything about it, it'll have to involve... a CustomResource.

@NGL321 NGL321 added the needs-triage This issue or PR still needs to be triaged. label Jun 17, 2019
@rix0rrr rix0rrr added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 27, 2019
@rix0rrr rix0rrr added the @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry label Jan 23, 2020
@rix0rrr rix0rrr assigned MrArnoldPalmer and unassigned rix0rrr Jan 23, 2020
@heiba
Copy link

heiba commented May 28, 2020

How can we raise this request the CloudFormation team to support force deletion of ECR repositories ?

@heiba
Copy link

heiba commented Jun 7, 2020

I created a new issue in the CloudFormation Coverage Roadmap repository
aws-cloudformation/cloudformation-coverage-roadmap#515

Please let me know if I should take another action to escalate this issue to the CloudFormation team

@peterwoodworth
Copy link
Contributor

It looks like the CFN team is looking at the issue @heiba created as of 11 days ago. Hopefully we'll be able to support this feature soon without the need for a custom resource

@NukaCody
Copy link

NukaCody commented Apr 20, 2021

It looks like something similiar is already done with S3, with a custom resource here.

@heiba
Copy link

heiba commented May 30, 2021

@MrArnoldPalmer @RomainMuller While I'm chasing the CloudFormation team to hopefully update us on this issue. Any chance the CDK team can implement it using a custom resource ?

@MrArnoldPalmer MrArnoldPalmer removed their assignment Jun 21, 2021
@heiba
Copy link

heiba commented Aug 7, 2021

@kirintwn referencing your new branch that includes deleting of ecr repos via a custom resource.

#12618

@TheRealAmazonKendra
Copy link
Contributor

Closing in favor of #12618. More or less a duplicate of that one.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants