Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ses): ConfigurationSet.reputationMetrics incorrect default value #30968

Closed
greg5123334 opened this issue Jul 29, 2024 · 3 comments · Fixed by #30979
Closed

(aws-ses): ConfigurationSet.reputationMetrics incorrect default value #30968

greg5123334 opened this issue Jul 29, 2024 · 3 comments · Fixed by #30979
Assignees
@ashishdhingra
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2

Comments

@greg5123334
Copy link
Contributor

Describe the issue

ses.ConfigurationSet.reputationMetrics states the default value for this property is false whereas in reality it defaults to true.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ses.ConfigurationSet.html#reputationmetrics
@greg5123334 greg5123334 added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ses Related to Amazon Simple Email Service label Jul 29, 2024
@ashishdhingra ashishdhingra self-assigned this Jul 29, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2024
@ashishdhingra
Copy link
Contributor

Reproducible using simple code new ses.ConfigurationSet(this, 'testconfigset'); which generates the following CloudFormation template:

Resources:
  testconfigsetC2A896EF:
    Type: AWS::SES::ConfigurationSet
    Metadata:
      aws:cdk:path: CdktestStack/testconfigset/Resource
  CDKMetadata:
    Type: AWS::CDK::Metadata
    Properties:
      Analytics: v2:deflate64:H4sIAAAAAAAA/12KQQ6DIBAA3+IdtmJ66dkf6AMaCqtZtEvCgh6Mf29IPXmaZGY6MM8XtI3dRTu/6JU+cIzZukXZXd6CAkcfeaK5JJsp8ohZ9RPf3VnlgBJLcngNnmo8FUePEOSxdS0YA6YJQqRT4UxfhOHPH4K+9g6JAAAA
    Metadata:
      aws:cdk:path: CdktestStack/CDKMetadata/Default
    Condition: CDKMetadataAvailable
...

Deploying it using cdk deploy command creates configuration set with Reputation metrics as enabled:
Screenshot 2024-07-29 at 4 10 15 PM

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 29, 2024
@ashishdhingra ashishdhingra mentioned this issue Jul 29, 2024
Merged
1 task
@ashishdhingra ashishdhingra changed the title (aws-ses): ConfigurationSet.reputationMetrics incorrec default value (aws-ses): ConfigurationSet.reputationMetrics incorrect default value Jul 30, 2024
@mergify mergify bot closed this as completed in #30979 Jul 30, 2024
@mergify mergify bot closed this as completed in d60aaa0 Jul 30, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ashishdhingra ashishdhingra

Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
2 participants
@ashishdhingra @greg5123334