(elbv2): unable to remove bucket policy dependency

[automartin5000]

Describe the bug

Attempting to remove the bucket policy dependency with cfnAlb.removeDependency(cfnAccessBuckePolicy) results in the following TypeError: target.shouldSynthesize is not a function`

Regression Issue

• Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

Dependency is removed

Current Behavior

Test suite failed to run - TypeError: target.shouldSynthesize is not a function

Reproduction Steps

alb.logAccessLogs(accessLogBucket);
const cfnAccessLogBucketPolicy = accessLogBucket.node.findChild("Policy") as CfnBucketPolicy;
const cfnAlb = alb.node.defaultChild as CfnLoadBalancer;
cfnAlb.removeDependency(cfnAccessLogBucketPolicy);

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.160

Framework Version

No response

Node.js Version

20.11.1

OS

Mac 14.6

Language

TypeScript

Language Version

5.4.5

Other information

No response

[khushail]

Hi @automartin5000 , thanks for reaching out.

The given code is giving error because the bucket policy is not identified as target.

aws-cdk/packages/aws-cdk-lib/core/lib/cfn-resource.ts

Line 319 in 0a606c9

if (!target.shouldSynthesize()) {

CFnBucketPolicy is different from BucketPolicy. You could try running this code -

    const cfnAlb = alb.node.findChild('Resource') as alb.CfnLoadBalancer
    const cfnBucket = accesslogbucket.node.findChild('Resource') as CfnBucket;
    //const cfnBucketPolicy = accesslogbucket.node.findChild('Policy') as CfnBucketPolicy;
    const cfnbucketPolicy = accesslogbucket.policy?.node.defaultChild as CfnBucketPolicy;
    cfnAlb.removeDependency(cfnbucketPolicy);

The result of cdk diff shows the policy being removed -

this should do the trick.
let me know if this does not work for you.

[automartin5000]

@khushail Thanks! I ended up not needing to remove the bucket policy, but that's good to know.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.