Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that Cloud Assembly is self-contained #5960

Closed
iliapolo opened this issue Jan 25, 2020 · 1 comment
Closed

Verify that Cloud Assembly is self-contained #5960

iliapolo opened this issue Jan 25, 2020 · 1 comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-discussion This issue/PR requires more discussion with community. p2

Comments

@iliapolo
Copy link
Contributor

❓ General Issue

Our current cloud-assembly integration tests don't really cover all the functionality we want.

The cloud-assembly directory must be self-contained and portable between machines and environments. This is especially critical for the CI/CD story.

This means that the cloud-assembly shouldn't include any references to the environment it was created on. See #5807.

However, our current tests dont verify this because the tests dont run in an isolated environment.

Specifically, we should at least make sure that the source, used by synth, is not available, when running cdk deploy.

The Question

Environment

  • CDK CLI Version: ALL
  • Module Version: ALL
  • OS: ALL
  • Language: ALL

Other information
@iliapolo iliapolo added the needs-triage This issue or PR still needs to be triaged. label Jan 25, 2020
@iliapolo iliapolo mentioned this issue Jan 25, 2020
Closed
@rix0rrr rix0rrr changed the title Cloud-Assembly Integration Tests Verify that Cloud Assembly is self-contained Feb 3, 2020
@SomayaB SomayaB added feature-request A feature should be added or improved. needs-discussion This issue/PR requires more discussion with community. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 26, 2020
@iliapolo iliapolo added the effort/medium Medium work item – several days of effort label Mar 16, 2020
@iliapolo iliapolo added the p2 label Aug 29, 2020
@iliapolo iliapolo removed their assignment Jun 27, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 28, 2022
@github-actions github-actions bot closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-discussion This issue/PR requires more discussion with community. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iliapolo @SomayaB