Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/mqtt/connect.cpp: comparison is always false due to limited range of data type #54

Closed
larsonmpdx opened this issue Nov 17, 2017 · 1 comment

Comments

@larsonmpdx
Copy link
Contributor

these comparisons are flagged by clang -wtype-limits. this causes the code after the comparison to never be executed:

https://github.com/aws/aws-iot-device-sdk-cpp/blob/master/src/mqtt/Connect.cpp#L137
https://github.com/aws/aws-iot-device-sdk-cpp/blob/master/src/mqtt/Connect.cpp#L163

this one is similar but just some extra code:

https://github.com/aws/aws-iot-device-sdk-cpp/blob/master/src/mqtt/Connect.cpp#L197

@vareddy-zz
Copy link
Contributor

Hi @larsonmpdx ,
I have made the fix for this and I'm currently running it through our internal test pipeline. I will commit to master after the testing completes.
Thanks!
Varun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants