From 751245afc26dbedcc477be3bc2f830e18d765e1d Mon Sep 17 00:00:00 2001 From: George Fu Date: Wed, 19 Oct 2022 21:03:41 -0400 Subject: [PATCH] fix(endpoint): join authScheme signingRegionSet values instead of taking first only (#4056) --- packages/middleware-signing/src/middleware.ts | 3 ++- packages/types/src/auth.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/middleware-signing/src/middleware.ts b/packages/middleware-signing/src/middleware.ts index dc3b4bcc06b2..a8905f9e6771 100644 --- a/packages/middleware-signing/src/middleware.ts +++ b/packages/middleware-signing/src/middleware.ts @@ -24,8 +24,9 @@ export const awsAuthMiddleware = // TODO(identityandauth): call authScheme resolver const authScheme: AuthScheme | undefined = context.endpointV2?.properties?.authSchemes?.[0]; + const multiRegionOverride: string | undefined = - authScheme?.name === "sigv4a" ? authScheme?.signingRegionSet?.[0] : undefined; + authScheme?.name === "sigv4a" ? authScheme?.signingRegionSet?.join(",") : undefined; const signer = await options.signer(authScheme); diff --git a/packages/types/src/auth.ts b/packages/types/src/auth.ts index 0d8964b6702a..01fb55ac75d8 100644 --- a/packages/types/src/auth.ts +++ b/packages/types/src/auth.ts @@ -15,7 +15,8 @@ export interface AuthScheme { */ signingRegion: string; /** - * TODO usage? + * @example ["*"] + * @exammple ["us-west-2", "us-east-1"] */ signingRegionSet?: string[]; /**