Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git merge with removed secrets in diff causes commit to fail #188

Open
Kyle-sandeman-mrdfood opened this issue Nov 3, 2020 · 0 comments

Comments

@Kyle-sandeman-mrdfood
Copy link

Steps to reproduce:

  1. create git repo
  2. commit some secrets on branch X
  3. create branch Y which removes those secrets
  4. merge Y into X: git checkout X && git merge Y --no-ff (a fast forward would happen for this simple case, let's skip that)

if it matters, alias gm='git merge'
img

Mac OSX Catalina, using git 2.25.0 creates a diff after the comments for a git merge:
Image 2020-11-03 13-10-05
The diff after the separator is NOT included in the actual commit message, but presumably because it is fed through STDIN, git-secrets refuses to commit. Additionally, git merge --no-verify does not seem to work (git commit --no-verify does work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant