Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect NPC model using Chinese client (zhCN or enCN) #10795

Open
adink1 opened this issue Feb 23, 2022 · 14 comments
Open

Incorrect NPC model using Chinese client (zhCN or enCN) #10795

adink1 opened this issue Feb 23, 2022 · 14 comments
Labels
70 TBC endgame content Confirmed DB related to the SQL database Needs sniff The issue/PR needs sniff data to be corrected.
Projects

Comments

@adink1
Copy link

adink1 commented Feb 23, 2022

Current Behaviour

Explore Isle of Quel'Danas Sunwell Plateau On the bridge outside, why did the NPCs change their appearance, am I the only one?

Expected Blizzlike Behaviour

none

Source

WoWScrnShot_022322_174502

Steps to reproduce the problem

go Explore Isle of Quel'Danas

Extra Notes

No response

AC rev. hash/commit

7435805

Operating system

Ubuntu20.04

Custom changes or Modules

No response

@adink1 adink1 changed the title NPC deformation Incorrect NPC model using Chinese client (zhCN or enCN) Feb 27, 2022
@heyitsbench
Copy link
Contributor

Confirmed an issue on enUS client as well on CC PTR
image
Shattered Sun Marksman and Warrior's both have this display issue.

@Gultask
Copy link
Contributor

Gultask commented May 21, 2022

Shattered Sun Warrior (ID: 25115)

  • Invisible (Display ID: 11686)
  • Imp (Display ID: 20570)

Shattered Sun Marksman (ID: 24938)

  • Invisible (Display ID: 11686)
  • Imp (Display ID: 20570)

SS

Using .npc add temp 37512 and 25142 seems to use the correct models but I'd double check. I think some race/gender combinations are missing.

@Gultask Gultask added Confirmed DB related to the SQL database 70 TBC endgame content labels May 21, 2022
@WowChenEd
Copy link

Shattered Sun Warrior (ID: 25115)

  • Invisible (Display ID: 11686)
  • Imp (Display ID: 20570)

Shattered Sun Marksman (ID: 24938)

  • Invisible (Display ID: 11686)
  • Imp (Display ID: 20570)

SS

Using .npc add temp 37512 and 25142 seems to use the correct models but I'd double check. I think some race/gender combinations are missing.

have you resolve it?
thanks

@Gultask
Copy link
Contributor

Gultask commented Jul 12, 2022

I believe modelids are sniffed values and I don't know much about modelids to know what/how/if to change them.
That comment I made wasn't a solution just some info I got because I had just started messing around with the DB 🙂

@heyitsbench
Copy link
Contributor

heyitsbench commented Jul 12, 2022

modelIDs are pulled from DBC files, at least to my knowledge, so those aren't getting changed.

Edit: Also goes through creature_model_info table.
Offending entries:
INSERT INTO `creature_model_info` (`DisplayID`, `BoundingRadius`, `CombatReach`, `Gender`, `DisplayID_Other_Gender`) VALUES (11686, 0.5, 1, 2, 0);

INSERT INTO `creature_model_info` (`DisplayID`, `BoundingRadius`, `CombatReach`, `Gender`, `DisplayID_Other_Gender`) VALUES (20570, 0, 0, 2, 0);

@heyitsbench
Copy link
Contributor

I think we should double check sniffs and try and see what's supposed to be there.

@Gultask Gultask added the Needs sniff The issue/PR needs sniff data to be corrected. label Jul 12, 2022
@heyitsbench
Copy link
Contributor

Okay, I submitted a sniff to the Google form for this. From my untrained eye, those display IDs are supposed to be there somewhere, but there's also a display ID of 22910 floating around for them as well. Would need someone a bit more familiar with sniffs to take a look to figure out what's going on with it.

@FallingSnow
Copy link

I'm experiencing this on a US client as well.
Screenshot from 2022-10-14 06-42-58
Screenshot from 2022-10-14 06-48-12

@acidmanifesto
Copy link
Contributor

acidmanifesto commented Oct 14, 2022

The shattered sun marksmen are suppose to appear and change their armor to your guild on a boss kill. which is why it is a invisble model and a imp model used. Fun fact, in retail imp models were reported to be visible as well, although obviously unintedned.

@Annamaria-CC Annamaria-CC added temporary label 70 TBC endgame content and removed 70 TBC endgame content temporary label labels Nov 1, 2022
@github-actions github-actions bot added this to To do in Content 70 Nov 1, 2022
@avarishd avarishd mentioned this issue Mar 15, 2023
@Mitradis

This comment was marked as off-topic.

@heyitsbench
Copy link
Contributor

UPDATE creature_template;

Those are sniffed values. Your proposed solution is a hackfix.

@Mitradis

This comment was marked as off-topic.

@acidmanifesto
Copy link
Contributor

you can use or not I don't care. Just one of my many fixes.

The npc is linked to a quest that allows phase. The issue is the invisible model is visible in the core, your fix is not even close to being valid and will not be used.

@azerothcore azerothcore locked and limited conversation to collaborators Mar 15, 2023
@azerothcore azerothcore unlocked this conversation Jun 20, 2023
@heyitsbench
Copy link
Contributor

heyitsbench commented Jun 21, 2023

Managed to find a few auras on these creatures in a packet that look to be responsible for the model change, at least most of it. Seems there are a bunch of server-side spells for the various race/gender combinations of the marksmen/warriors for each phase (tier as Blizz calls them) of the Isle. The list of which can be found in this gist. (Edit: Auras and their assignments in this list are based solely on their names in the server-side spell_dbc table, not necessarily based on sniffed data.)

As far as I know, the Isle is supposed to be fully progressed on a fresh Wrath realm, so the tier of auras to assign to these NPCs for the purposes of AC would be the final fourth set, though I've still yet to determine if race/gender are arbitrarily determined through those auras alone or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
70 TBC endgame content Confirmed DB related to the SQL database Needs sniff The issue/PR needs sniff data to be corrected.
Projects
Content 70
  
To do
Development

No branches or pull requests

8 participants