-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect NPC model using Chinese client (zhCN or enCN) #10795
Comments
Shattered Sun Warrior (ID: 25115)
Shattered Sun Marksman (ID: 24938)
Using .npc add temp 37512 and 25142 seems to use the correct models but I'd double check. I think some race/gender combinations are missing. |
have you resolve it? |
I believe modelids are sniffed values and I don't know much about modelids to know what/how/if to change them. |
modelIDs are pulled from DBC files, at least to my knowledge, so those aren't getting changed. Edit: Also goes through creature_model_info table.
|
I think we should double check sniffs and try and see what's supposed to be there. |
Okay, I submitted a sniff to the Google form for this. From my untrained eye, those display IDs are supposed to be there somewhere, but there's also a display ID of 22910 floating around for them as well. Would need someone a bit more familiar with sniffs to take a look to figure out what's going on with it. |
The shattered sun marksmen are suppose to appear and change their armor to your guild on a boss kill. which is why it is a invisble model and a imp model used. Fun fact, in retail imp models were reported to be visible as well, although obviously unintedned. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Those are sniffed values. Your proposed solution is a hackfix. |
This comment was marked as off-topic.
This comment was marked as off-topic.
The npc is linked to a quest that allows phase. The issue is the invisible model is visible in the core, your fix is not even close to being valid and will not be used. |
Managed to find a few auras on these creatures in a packet that look to be responsible for the model change, at least most of it. Seems there are a bunch of server-side spells for the various race/gender combinations of the marksmen/warriors for each phase (tier as Blizz calls them) of the Isle. The list of which can be found in this gist. (Edit: Auras and their assignments in this list are based solely on their names in the server-side As far as I know, the Isle is supposed to be fully progressed on a fresh Wrath realm, so the tier of auras to assign to these NPCs for the purposes of AC would be the final fourth set, though I've still yet to determine if race/gender are arbitrarily determined through those auras alone or something else. |
Current Behaviour
Explore Isle of Quel'Danas Sunwell Plateau On the bridge outside, why did the NPCs change their appearance, am I the only one?
Expected Blizzlike Behaviour
none
Source
Steps to reproduce the problem
go Explore Isle of Quel'Danas
Extra Notes
No response
AC rev. hash/commit
7435805
Operating system
Ubuntu20.04
Custom changes or Modules
No response
The text was updated successfully, but these errors were encountered: