Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICD on equip issue #19030

Open
Joshmash opened this issue Jun 8, 2024 · 7 comments
Open

ICD on equip issue #19030

Joshmash opened this issue Jun 8, 2024 · 7 comments

Comments

@Joshmash
Copy link

Joshmash commented Jun 8, 2024

Current Behaviour

Weapons with effects and relics have icd. After equipping they can't give any buffs/effects for 30 seconds

Expected Blizzlike Behaviour

They should not have icd after equipping

Source

https://www.youtube.com/watch?v=rNVoMGRg4QE&t=200s after switching to Shadowmourne he instantly gets soul shard.

This video i found from other project WoWManiaUK/Redemption#5114

Steps to reproduce the problem

  1. Equip Shadowmourne
  2. Start attacking before 30 sec have passed
  3. See the results

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. 1898135+ 2024-05-29 06:47:51 +0300 (TS branch) (Unix, RelWithDebInfo, Static)

Operating system

Ubuntu 22.04.4 LTS

Custom changes or Modules

  • mod-cfbg
  • mod-congrats-on-level
  • mod-duel-reset
  • mod-globalchat
  • mod-individual-xp
  • mod-transmog
@Kitzunu
Copy link
Member

Kitzunu commented Jun 8, 2024

Need ITEM_FLAG_NO_EQUIP_COOLDOWN

@YggdrasilWotLK
Copy link

YggdrasilWotLK commented Jun 14, 2024

Might this be a blanket fix relevant for this issue? :)

Edit: Changed to consider whether flag 128 is already applied

UPDATE item_template
SET Flags = Flags | 128
WHERE class = 2
AND (Flags & 128) = 0;

UPDATE item_template
SET Flags = Flags | 128
WHERE class = 4
AND subclass IN (6, 7, 8, 9, 10)
AND (Flags & 128) = 0;

@heyitsbench
Copy link
Contributor

Might be a duplicate of #8389.

@Kitzunu
Copy link
Member

Kitzunu commented Jun 20, 2024

Using class = 2 could work, but can't do class = 4 because that includes trinkets which should have an ICD on equip

@YggdrasilWotLK
Copy link

That's why I added subclass 6-10 as well to item class 4, so that it'll only be applied to Shields, Librams, Idols, Totems, and Sigils :)

However, I just tested this SQL script on my server but still have a 30-sec on equip CD on both passive and active weapon slot item procs. I'll let you know if I find another approach :)

@Kitzunu
Copy link
Member

Kitzunu commented Jun 21, 2024

Oh I missed it, my bad

@Kitzunu
Copy link
Member

Kitzunu commented Jun 26, 2024

Did you delete cahce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants