Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Gameobject): Pumpkin wrong placement #2057

Merged
merged 4 commits into from
Jul 17, 2019
Merged

fix(DB/Gameobject): Pumpkin wrong placement #2057

merged 4 commits into from
Jul 17, 2019

Conversation

ELdoBA
Copy link
Contributor

@ELdoBA ELdoBA commented Jul 4, 2019

Delete wrong spawned gobject

CHANGES PROPOSED:
  • Delete
ISSUES ADDRESSED:

Closes #2056 #542

TESTS PERFORMED:

Wrongly spawned gameobject, doesn't need tot be there.

HOW TO TEST THE CHANGES:
  1. .go gob 78033
KNOWN ISSUES AND TODO LIST:
  • [ ]
  • [ ]
Target branch(es):

Master

- Delete wrongly placed pumpkin in Silvermoon
@ghost
Copy link

ghost commented Jul 4, 2019

Instead of just deleting it, why not add it to the appropriate event (Hallow's End)? There are also 3 other GUIDs missing of the same type:

DELETE FROM `game_event_gameobject` WHERE `guid` IN (78033,78106,78117);
INSERT INTO `game_event_gameobject` (`eventEntry`, `guid`)
VALUES
(12,78033),
(12,78106),
(12,78117);

- Added to other event
@ELdoBA
Copy link
Contributor Author

ELdoBA commented Jul 4, 2019

Instead of just deleting it, why not add it to the appropriate event (Hallow's End)? There are also 3 other GUIDs missing of the same type:

DELETE FROM `game_event_gameobject` WHERE `guid` IN (78033,78106,78117);
INSERT INTO `game_event_gameobject` (`eventEntry`, `guid`)
VALUES
(12,78033),
(12,78106),
(12,78117);

Yeah better solution. Updated , thank you

@ELdoBA ELdoBA requested a review from a user July 4, 2019 11:39
@Knindzagxg
Copy link
Member

Checked ingame, all good.

@ghost
Copy link

ghost commented Jul 5, 2019

Added a few more Hallow's End game objects that I identified (hanging ghosts, various pumpkins).

@andoys
Copy link

andoys commented Jul 7, 2019

Thank you for this fix

@ELdoBA ELdoBA merged commit cb15707 into azerothcore:master Jul 17, 2019
@ELdoBA ELdoBA deleted the deletewrongplacementofpupkin branch July 17, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Minor) Wrong placement of pumpkin object? Midsummer Fire Festival
4 participants