Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DB/Quest): Shoot 'Em Down #2915

Merged
merged 1 commit into from
Apr 29, 2020
Merged

fix(DB/Quest): Shoot 'Em Down #2915

merged 1 commit into from
Apr 29, 2020

Conversation

Kitzunu
Copy link
Member

@Kitzunu Kitzunu commented Apr 21, 2020

CHANGES PROPOSED:

  • Change spawn HP (curhealth) to it's max (126000)
    Proof https://youtu.be/KqGiOV8Dofg?t=76 You can see that he gets 4 successful shots on the dragon to make him die.
    Basic maths:
    126000 * 0.26 = 32760 (damage per shot by harpoon)
    32760 * 4 = 131040 (Dragon = DEAD! :) )
  • Change condition from using spell 56578 since the harpoon use spell 56570
  • Add smart_scripts to set passive on reset to fix the issue of constant combat bug here: Shoot 'Em Up (Quest) - Stuck in combat bug [$5 awarded] #2071

ISSUES ADDRESSED:

TESTS PERFORMED:

  • Ran SQL
  • Tested in-game (Works :) )

HOW TO TEST THE CHANGES:

  1. .go c id 30337
  2. .q add 13069
  3. Jump in a harpoon gun and shoot some proto-drakes 🗡️

KNOWN ISSUES AND TODO LIST:

Target branch(es):

  • Master

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

@DevMatheuss
Copy link
Contributor

it worked for me.

@Kitzunu Kitzunu merged commit 8014aee into azerothcore:master Apr 29, 2020
@Kitzunu
Copy link
Member Author

Kitzunu commented Apr 29, 2020

Thank you @merdlin for the test & @FrancescoBorzi for the review

@Kitzunu Kitzunu deleted the fix-shoot'emup branch April 29, 2020 03:00
@Yehonal
Copy link
Member

Yehonal commented May 1, 2020

Congrats :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoBorzi FrancescoBorzi FrancescoBorzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shoot 'Em Up (Quest) - Stuck in combat bug [$5 awarded]
5 participants
@Kitzunu @DevMatheuss @Yehonal @FrancescoBorzi @Helias