fix(DB/gameobject): Fixes quest In Memoriam #2300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test this using the latest commit and a fresh DB? This should already have been fixed in PR #2231. Only the phase of the object was wrong (as you proceed through the "Sons of Hodir" quest chain the area "Thunderfall" is phased). |
|
As a side note: The faction of a game object does not affect it's visibility, it only affects damage calculation through spells. Visibility is controlled via phase mask of the game object. |
FrancescoBorzi
approved these changes
Sep 22, 2019
|
Ok, tested on commit 6ebd64e with a fresh DB and the quest is working fine, so this PR is not needed. |
|
Indeed this was fixed, the way i tested was wrong. Good job @Stoabrogga with that PR! I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES PROPOSED:
ISSUES ADDRESSED:
TESTS PERFORMED:
.go go 268627
.sum Normal_Player ( Non GM )
HOW TO TEST THE CHANGES:
.go go 268627
.sum Normal_Player ( Non GM )
KNOWN ISSUES AND TODO LIST:
Target branch(es):
How to test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR