-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Core/Worldsession): add option to prevent logout when AFK in a sanctuary zone #2205
Conversation
Yes - will complete the fix tonight |
This is the packet issue @lineagedr was talking about the yellow spam message |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The message is most likely generated by the client |
yes. it's client generated so nothing to do about it :| |
Code looks ok, so is this still WIP or is it ready to be merged? |
One question is there any way to modify it so that it not only works in the sanctuary, but throughout the world? |
Does the server send a move or jump instruction to the client? |
Should be easy to implement, perhaps we could adjust this PR for this:
|
As far as I understand this the client sends a "logout" request to the server (e.g. if too long AFK or triggered by the player) and the server can deny or accept the logout. You can also do nothing about the yellow message because this is written by the client, not the server. |
@mik1893 @Stoabrogga Can the server send"move"or"jump"instructions to the client? |
I don't think this is possible. Also to my understanding the client sets the AFK state, so it would not matter if the server forces actions on the player. But I don't have deep knowledge concerning the client / server communication, so could be totally wrong here. |
@mik1893 |
I added the 3rd option and tested this successfully:
As this PR does not cause any harm (option 0 is default) and it is a nice addition to the core I think this is ready to be merged. |
Closes #2139
This will prevent logout by sending a reason for denying logout - preventing CMSG_LOGOUT_REQUEST to be spammed again immediatly.