[Request] Implement last IKE3 playerbot

[nero08]

Feature Request: Implement IKE3 playerbot on last azerothcore.

Here is the playerbot module: https://github.com/ike3/mangosbot-bots/commits/master

And last time ike3 merge with trinitycore: https://github.com/ike3/mangosbot/tree/trinity-wotlk-ai

Thanks in advance.

** EDIT BY ADMIN: **

It would be nice if this can be done preferably in a module. If not, in the worst case, as a configurable feature disabled by default (that does not impact anything else when disabled).

[FrancescoBorzi]

@nero08 where is the reward? please post it using Bountysource

[nero08]

@nero08 where is the reward? please post it using Bountysource

@FrancescoBorzi see again

[FrancescoBorzi]

@nero08 thanks a lot, also let me know if you're on Discord (you can contact me privately)

[solidmaxtor]

I'm in =)

[FrancescoBorzi]

As mentioned on discord, it would be nice if this can be done preferably in a module. If not, in the worst case, as a configurable feature disabled by default (that does not impact anything else when disabled).

[wowmane]

good job !

[Viste]

to low bounty for this( just my opinion)

[FrancescoBorzi]

Bounties are there to help, they are just an extra bonus and we are very thankful to backers, even when they post little amounts. However 100$ is not a little amount, maybe it's not proportional to the amount of work needed, but we do appreciate it.

[nero08]

200$ now @FrancescoBorzi

[Winfidonarleyan]

Hmm, hmm

[FrancescoBorzi]

thanks a lot @nero08

[nero08]

Link of better recent sources:

https://github.com/conan513/SingleCore-AC branch bot+custom

But CMakeList is incompatible since:

eae9aff#diff-9c4a789a0cb66ac82ec640d8fa1fb592

[nero08]

@Psilovybin

https://github.com/Psilovybin/azcore-acbot/commits/acbot

[Psilovybin]

As mentioned on discord, it would be nice if this can be done preferably in a module. If not, in the worst case, as a configurable feature disabled by default (that does not impact anything else when disabled).

It would be cool if this were made into a module, much easier to implement as a drop in, but i'm afraid there is too many hooks into the main code to do this. I was trying to do something like that but there's no way around the hooks.

[nero08]

Or just use another branch if it's not possible

@Psilovybin On your project, you don't update your cmakelist file to the new rewrite cmake include system, maybe it will be easier if we update it? Do you think it's only because AzerothCore does not use BOOST lib?

[nero08]

We have to implement it like worldserver folder or scripts folder at this time with checkbox option on cmake to include it

[Psilovybin]

Or just use another branch if it's not possible

@Psilovybin On your project, you don't update your cmakelist file to the new rewrite cmake include system, maybe it will be easier if we update it? Do you think it's only because AzerothCore does not use BOOST lib?

I've pretty much abandoned that, only still have it up for reference

[Trystanosaurus]

I don't know if it helps but Jokerlfm had been working on getting Ike3 bots into Azeroth Core. This was around November 2017 in the below repository, since then I think he's undone some of that and started working on his own bots.

https://github.com/jokerlfm/azerothcore-wotlk

[FALL1N1]

Is "IKE3 playerbots" any different than https://github.com/trickerer/Trinity-Bots? If not, it can easily be backported.

[LukasVolgger]

Yes it is. Trickerer uses NPC bots while IKE3 bots are in fact fake Players.

I asked Trickerer a long time ago to backport his mod to AC but he didn't want to....

If you could do this, that would be awesome like your other PR's <3

[Trystanosaurus]

Is "IKE3 playerbots" any different than https://github.com/trickerer/Trinity-Bots? If not, it can easily be backported.

The trinity bots there look like NPC bots (i.e. they don't have character data like a player does), you hire them from an NPC and they follow you about helping.

The IKE3 ones iirc were player bots and once you logged them in they would run around farming or whatever else they were set to until you asked them to your party or recruited them through raid finder https://ike3.github.io/mangosbot-docs/

In practical terms there's not the biggest difference, though player bots (since they are just characters in the database) allow you to kind of multibox with AI's controlling your extra characters and switch between them when you want.

[fatbeardpirate]

Playerbots > NPCBots ...

Playerbots are summoned from the players own account and are alot more fun - their equipment persists.

[Murachacha]

Any updates on this?

[UltraNix]

I will try to adopt that to azerothcore, but I can't guarantee anything :)
@FrancescoBorzi Assign me.

[biancong1208]

I have fixed several issues causing crash and have now bots running without crashes and fewer console errors. If anyone is interested in helping test, please use the module code from repo here: https://github.com/ZhengPeiRu21/mod-playerbots
Compile using Playerbots branch of my AzerothCore fork repo - I keep it up to date with master, but it has the changes needed for Playerbots to work. I don't know yet best approach to add these as hooks to master, as it requires things like overloaded constructor which would be hard to implement with hooks. For now, please use this branch: https://github.com/ZhengPeiRu21/azerothcore-wotlk/tree/Playerbot
I will continue to work on these and add improvement from upstream. Please kindly share any feedbacks or problems you find!

I am getting errors when compiling, is it my problem?

you will only be able to compile if you use the recommended source.

Yes, my source code is copied from https://github.com/ZhengPeiRu21/azerothcore-wotlk/tree/Playerbot

I also have errors when trying to compile the same source.

Dude, this source is not the correct one. I compiled normally.

Hi, can you share the correct source code?

[Bogir]

Hi, can you share the correct source code?

It is not a kind of Release. Just some fixes. If something still wrong - try to fix it and assign your development here

[biancong1208]

Hi, can you share the correct source code?

It is not a kind of Release. Just some fixes. If something still wrong - try to fix it and assign your development here

I'm really sorry, I'm not a developer and I don't know how to fix it.

[rogerc66]

I have fixed several issues causing crash and have now bots running without crashes and fewer console errors. If anyone is interested in helping test, please use the module code from repo here: https://github.com/ZhengPeiRu21/mod-playerbots
Compile using Playerbots branch of my AzerothCore fork repo - I keep it up to date with master, but it has the changes needed for Playerbots to work. I don't know yet best approach to add these as hooks to master, as it requires things like overloaded constructor which would be hard to implement with hooks. For now, please use this branch: https://github.com/ZhengPeiRu21/azerothcore-wotlk/tree/Playerbot
I will continue to work on these and add improvement from upstream. Please kindly share any feedbacks or problems you find!

I am getting errors when compiling, is it my problem?

you will only be able to compile if you use the recommended source.

Yes, my source code is copied from https://github.com/ZhengPeiRu21/azerothcore-wotlk/tree/Playerbot

I also have errors when trying to compile the same source.

Dude, this source is not the correct one. I compiled normally.

Just curious, do I have to put the mod Repo of the first link into the modules folder of 2nd link Repo? or the 2nd link is already made hard coded integration of playerbot?

[ZhengPeiRu21]

Thank you all for support. ^_^ And thank you for share crash logs - it is very helpful to solve the problems.

Just curious, do I have to put the mod Repo of the first link into the modules folder of 2nd link Repo? or the 2nd link is already made hard coded integration of playerbot?

The module should be installed like a regular AzerothCore module - place it in the modules directory and run the SQL files.

For everyone having trouble compiling, please ensure you are on the correct branch. If you have cloned using Git, it will be the repo with all different branches. Make sure you are on Playerbot branch. Also please ensure module is on the AzerothCore branch.

@biancong1208 You maybe have the correct code and branch but the MOD_PLAYERBOTS define is not being trigger. Please ensure you run cmake after placing module in correct directory.

[Bogir]

Thank you all for support. ^_^

small issue

[ZhengPeiRu21]

Thank you all for support. ^_^

small issue

Oh, yes, I missed ifdef tags there! That will cause compile to fail if module is not present. Thank you for finding! I will fix it.

[Greyisttot]

I have been paying attention to this issue for a long time, as if it has become popular, thank you cute girl @ZhengPeiRu21 ❤️

[heyitsbench]

I will point out that you don't need to quote

the entire previous message

in every reply you make in this issue. Makes it very difficult to keep up with this issue through the Github notifications in the AC Discord. (Also makes my phone crash because so much text gets loaded.)

[Nyeriah]

Maybe you guys would like to join our Discord to chat about this? GitHub is useful for discussions, but not so much for chatting. This issue alone has over 130 messages, out of which 93 are hidden because there are so many and it hit the threshold.

https://discord.gg/53mMbXjA

[biancong1208]

I have successfully compiled and entered the game, but I see that there are some problems:

1. The playerbot does not seem to know to turn around, even if it is being attacked.
2. The playerbot seems to rarely attack actively, mostly standing and making different expressions.
3. The playerbot control plugin - Mangosbot cannot be used.
4. An error is displayed when talking to the playerbot.
   @ZhengPeiRu21 Thanks for your guidance and hard work so I can experience playerbot at acerothcore.

[htc16]

Compilei e entrei no jogo com sucesso, mas vejo que existem alguns problemas:

1. O playerbot parece não saber se virar, mesmo que esteja sendo atacado.
2. O playerbot parece raramente atacar ativamente, principalmente em pé e fazendo expressões diferentes.
3. O plugin de controle do playerbot - Mangosbot não pode ser usado.
4. Um erro é exibido ao falar com o playerbot.
   @ZhengPeiRu21 Obrigado por sua orientação e trabalho duro para que eu possa experimentar o playerbot no acerothcore.

Bots work, you just can't have GM on and invisibility.

[biancong1208]

Bots work, you just can't have GM on and invisibility.

Yes, I use a level 1 account and I am not invisible.

[htc16]

I understood. So be patient, because critical crash bugs are still being fixed.

[ZhengPeiRu21]

I have successfully compiled and entered the game, but I see that there are some problems:

1. The playerbot does not seem to know to turn around, even if it is being attacked.

2. The playerbot seems to rarely attack actively, mostly standing and making different expressions.

3. The playerbot control plugin - [Mangosbot](https://github.com/celguar/mangosbot-addon) cannot be used.

4. An error is displayed when talking to the playerbot.
   @ZhengPeiRu21 Thanks for your guidance and hard work so I can experience playerbot at acerothcore.

Thank you for post a report. I am investigating issue of bot AI being slow. They are not attacking because many attack actions are expiring before they execute. Hopefully this can resolve soon!

The addon probably needs to be changed and updated for this port. I will investigate this if I have time but it is a lower priority.

Could you open an issue in the module repo with details for the error you see when talk to the bot?

[rogerc66]

I'm still having difficulties to compile ZhengPeiRu21's source.

I have made sure source is on Playerbot branch and mod in module folders but compiler still complaint many warning msg and enventually generate errors.
it makes me wonder, did I miss any dependencies or libs? but I can compile azerothcore master source along many mods without flaws, How to verify what's the problem?
My environment is a Ubuntu 20.04 vm running on a NAS system, compile environment shouldnt have any problems, otherwise it wont compile other source without problem. I could compile trinitycore and azerothcore master without problem.

[biancong1208]

Thank you for post a report. I am investigating issue of bot AI being slow. They are not attacking because many attack actions are expiring before they execute. Hopefully this can resolve soon!

The addon probably needs to be changed and updated for this port. I will investigate this if I have time but it is a lower priority.

Could you open an issue in the module repo with details for the error you see when talk to the bot?

Thank you for taking the time to fix the playerbot, I will continue to compile and play and experience, I will open an issue in the module repo to feedback the problem.
thanks again.

[biancong1208]

My environment is a Ubuntu 20.04 vm running on a NAS system, compile environment shouldnt have any problems, otherwise it wont compile other source without problem. I could compile trinitycore and azerothcore master without problem.

I'm a layman, I use windows to compile, I can't understand why you fail to compile.

[htc16]

I'm still having difficulties to compile ZhengPeiRu21's source.

I have made sure source is on Playerbot branch and mod in module folders but compiler still complaint many warning msg and enventually generate errors. it makes me wonder, did I miss any dependencies or libs? but I can compile azerothcore master source along many mods without flaws, How to verify what's the problem? My environment is a Ubuntu 20.04 vm running on a NAS system, compile environment shouldnt have any problems, otherwise it wont compile other source without problem. I could compile trinitycore and azerothcore master without problem.

look here: ZhengPeiRu21/mod-playerbots#8

[rogerc66]

look here: ZhengPeiRu21/mod-playerbots#8

I have managed get pass to 72% and now stopped at 73%, any suggestion?

[Winfidonarleyan]

Why are you trying to use a module that doesn't work and isn't finished and then writing here that it doesn't work?

[Bogir]

Why are you trying to use a module that doesn't work?

Because for some it works and for others it doesn't. Development continues :)

[htc16]

I couldn't help but opine here, all about this request.

It's resolved here: https://github.com/ZhengPeiRu21/mod-playerbots

After this PR ZhengPeiRu21/mod-playerbots#115 when Zheng analyze, the bots will be independent.

We definitely have bots in azerothcore.

So my humble opinion is that @ZhengPeiRu21 and @UltraNix solved this bot implementation in azerothcore.

[heyitsbench]

I don't know that this can be considered solved until enabling bots is either a matter of dropping the module into the folder or setting an option in the worldserver config. Currently a separate fork is required, and that in my opinion is enough to keep this issue open.

[htc16]

Oh, that being so, you are right.
For this not to be infinitely open could be added the way you said.
For it seems to me that this will never be resolved and closed the way it is at the moment.

And on the other hand, there is the solution!