Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Boss ICC 25] Sindragosa - Ice Tomb and Frost Imbued Blade buff Issue #2201

Closed
andoys opened this issue Aug 13, 2019 · 5 comments
Closed

[Boss ICC 25] Sindragosa - Ice Tomb and Frost Imbued Blade buff Issue #2201

andoys opened this issue Aug 13, 2019 · 5 comments

Comments

@andoys
Copy link

andoys commented Aug 13, 2019

[Boss ICC 25] Sindragosa - Ice Tomb and Frost Imbued Blade buff Issue

SMALL DESCRIPTION:

If player has Frost Imbued Blade buff and he is hit by Ice Tomb he is immune. Player with Frost Imbued shouldn't be targeted by Ice Tomb it should pick other players.

EXPECTED BLIZZLIKE BEHAVIOUR:

If you have Frost Imbued Blade buff you can't be targeted with Ice Tomb. So other players always get targeted
But if you do Solo run, Ice Tomb always miss/immune/no effect because no other player? or because you have Frost Imbued blade buff

CURRENT BEHAVIOUR:

Watch video: https://youtu.be/9OJCylVHcqk

5 characters targeted by Sindragosa for Ice Tombs
Look at raid marker X he has Frost Imbued Blade Buff but once he is targeted by Ice Tomb and gets hit by it. He is immune. No Ice Tomb appears. All 4 other players got Ice Tomb.

Ice tomb is important to reset the Mystic Buffet buff
No Mystic Buffet = Wipe

STEPS TO REPRODUCE THE PROBLEM:
  1. Get Shadowmourne quest -> https://www.wowhead.com/quest=24757/frost-infusion
  2. Start raid 25 man Sindragosa
  3. Equip Shadow's Edge
  4. Get hit by frost breath 4 times by Sindragosa
  5. You now have 4 stacks https://www.wowhead.com/spell=72292/frost-infusion
  6. You now have https://www.wowhead.com/spell=72290/frost-imbued-blade
  7. Wait and get hit by Ice Tomb
EXTRA NOTES:
BRANCH(ES):

master

AC HASH/COMMIT:

ef377b9

OPERATING SYSTEM:

Ubuntu 16/18

MODULES:
OTHER CUSTOMIZATIONS:

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@andoys andoys changed the title [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion = immune bug [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion get Frost Imbued Blade = immune bug Aug 13, 2019
@andoys andoys changed the title [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion get Frost Imbued Blade = immune bug [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion buff = Frost Imbued Blade buff = immune to Ice Tomb bug Aug 13, 2019
@andoys andoys changed the title [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion buff = Frost Imbued Blade buff = immune to Ice Tomb bug [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion buff/Frost Imbued Blade buff = immune to Ice Tomb bug Aug 13, 2019
@Ali-Khazaee
Copy link
Contributor

Ali-Khazaee commented Aug 13, 2019

  1. Open boss_sindragosa.cpp
  2. Find this word class SindragosaIceTombCheck
  3. Replace it's code body to this
class SindragosaIceTombCheck
{
    public:
        bool operator()(Unit* unit) const
        {
            return unit->HasAura(SPELL_FROST_IMBUED_BLADE) || unit->IsImmunedToDamageOrSchool(SPELL_SCHOOL_MASK_ALL);
        }

        bool operator()(WorldObject* object) const
        {
            return object->ToUnit() && (object->ToUnit()->HasAura(SPELL_FROST_IMBUED_BLADE) || object->ToUnit()->IsImmunedToDamageOrSchool(SPELL_SCHOOL_MASK_ALL));
        }
};

After this change if player has Imbued_blade buff will not be targeted by sindragosa ice tomb

@andoys andoys changed the title [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion buff/Frost Imbued Blade buff = immune to Ice Tomb bug [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion buff/Frost Imbued Blade buff - Ice Tomb issue Aug 14, 2019
@andoys
Copy link
Author

andoys commented Aug 14, 2019

Great work @Ali-Khazaee :D best fix

@FrancescoBorzi
Copy link
Contributor

@Ali-Khazaee can you please open a PR with it?

@andoys andoys changed the title [Boss ICC 25] Sindragosa - Ice Tomb and 4 Stacks of Frost Infusion buff/Frost Imbued Blade buff - Ice Tomb issue [Boss ICC 25] Sindragosa - Ice Tomb and Frost Imbued Blade buff - Ice Tomb issue Aug 14, 2019
@andoys andoys changed the title [Boss ICC 25] Sindragosa - Ice Tomb and Frost Imbued Blade buff - Ice Tomb issue [Boss ICC 25] Sindragosa - Ice Tomb and Frost Imbued Blade buff Issue Aug 14, 2019
@Ali-Khazaee Ali-Khazaee mentioned this issue Aug 14, 2019
@Ali-Khazaee
Copy link
Contributor

@FrancescoBorzi Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants