Core/Commands [Implement kickdelay command] #14250

hguy23 · 2022-12-17T06:32:34Z

Changes Proposed:

Implemented kickdelay/bandelay commands

Issues Addressed:

Closes 2 new functions: delayedKick(), delayedBan() #2817

Tests Performed:

Builds and test ingame

How to Test the Changes:

Example commands:
.kickdelay test Cheating 10 <- 10 means seconds
.bandelay ip 147.232.22.53 1d Cheating 10
.bandelay account test 1d Cheating 10

Type .kickdelay $charactername $reason $delay_time or .bandelay account $acc_name $bantime $reason $delay_time or .bandelay ip $acc_ip $bantime $reason $delay_time
Announce from $reason will appear at client.
Wait $delay_time given time until kick/ban.
Profit?

Known Issues and TODO List:

[ ]
[ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

…lse]

hguy23 · 2022-12-17T09:04:22Z

Should I ignore that codefactor issue ? https://www.codefactor.io/repository/github/azerothcore/azerothcore-wotlk/pull/14250

Kitzunu

Apart from that I still don't see the point of delayed commands, here are some things to improve.

Yes, you can ignore CodeFactor

Thanks fo the PR.

data/sql/updates/pending_db_world/rev_1671258222610106000.sql

src/server/scripts/Commands/cs_ban.cpp

src/server/game/Entities/Player/PlayerUpdates.cpp

src/server/game/Misc/BanMgr.cpp

src/server/scripts/Commands/cs_ban.cpp

src/server/scripts/Commands/cs_misc.cpp

data/sql/updates/pending_db_world/rev_1671258222610106000.sql

src/server/scripts/Commands/cs_misc.cpp

hguy23 · 2022-12-18T09:07:43Z

Removed min_time and max_time, in my opinion this is uselles to pick random time, just delay it with one value.

acidmanifesto · 2022-12-18T23:56:59Z

@frytik can you update the the how to test portion. I may know someone who may be interested in testing this out.
@55Honey this is a delay kick and ban gm cmd if you want to test this. I remember we had a prior conversation about this feature before.

hguy23 · 2022-12-19T05:58:42Z

Thanks for the PR. The purpose of a delayed ban, is to leave the affected accounts owner clueless what exact action has triggered it. So it shouldn't interact with the banned player at all. It may definitely NOT send a message announcing a ban to be useful.

So I have just to remove notification from player, and we are good to go?

55Honey · 2022-12-19T12:18:08Z

So I have just to remove notification from player, and we are good to go?

In terms of features, that's my only request. I'll leave the actual code to the other devs.

hguy23 · 2022-12-19T12:30:55Z

So I have just to remove notification from player, and we are good to go?

In terms of features, that's my only request. I'll leave the actual code to the other devs.

Changed.

src/server/game/Entities/Player/Player.h

Kitzunu · 2022-12-19T23:39:10Z

src/server/game/Misc/BanMgr.cpp


    LoginDatabase.CommitTransaction(trans);

-    if (sWorld->getBoolConfig(CONFIG_SHOW_BAN_IN_WORLD))
+    if (sWorld->getBoolConfig(CONFIG_SHOW_BAN_IN_WORLD) && !delay)


Why are excluding delayed banns? Add another config for it instead

Because we shouldn't show ban reason in chat for delayed ban, because kick is comming after certain time.

I'd still say add a config for it

Why do you need config for that ? You have to skip this message if you are doing bandelay, cause this message is handled in bandelay function.

If you keep this option with config, banned player will see reason in chat before kick out of game.

No, keep the config default off. Perhaps someone would like the message to show, and therefore should have the option for it

src/server/game/Misc/BanMgr.cpp

Kitzunu · 2022-12-19T23:44:08Z

src/server/scripts/Commands/cs_misc.cpp

+            kickReasonStr = std::string{ *reason };
+        }
+
+        targetPlayer->KickPlayer(kickReasonStr, Seconds(Acore::StringTo<int32>(delay_time).value_or(0)));


I am not the best when it comes to CommandHandler, but cant we pass the delay_time argument directly as Chrono by just needing the user to specify ms/s/d when using the command, to avoid the 3 way conversion?

Sadly I don't know. Every other command parsing it same way.

Ok just checking

Core/Commands [Requested changes]

hguy23 · 2022-12-20T00:56:03Z

Reworked whole announce system for kick/ban, now everything is in separate function, so should be better readable

acidmanifesto · 2022-12-20T01:08:19Z

Reworked whole announce system for kick/ban, now everything is in separate function, so should be better readable

Ill give this a test run the next 48hrs when i got a opening in my schedule

hguy23 · 2022-12-20T03:39:05Z

Reworked whole announce system for kick/ban, now everything is in separate function, so should be better readable

Ill give this a test run the next 48hrs when i got a opening in my schedule

Save you some time :D

Video2.mp4

55Honey · 2022-12-20T15:18:32Z

Thanks for the video!
I don't see a delay timer given in the bandelay command you have used in the video I wonder how the syntax is?

hguy23 · 2022-12-20T15:23:55Z

Thanks for the video! I don't see a delay timer given in the bandelay command you have used in the video I wonder how the syntax is?

.bandelay account $acc_name $bantime $reason $delay_time

That number five at end of command means delay time

Kitzunu · 2022-12-22T10:31:50Z

#14250 (comment)

acidmanifesto · 2023-01-27T14:21:42Z

applying run-build label to see if workflow passes. failure not related to pr.

acidmanifesto

ghost · 2023-02-05T18:22:11Z

Tested with 2 char and work fine for the two commands. Thanks

Gozzim · 2023-02-12T18:48:45Z

One question and a comment if I may, just went over the PR list and read it out of curiosity.

Why not just add this to the default kick and ban commands and default to no delay if none is given?
That way we don't get a new command and have a better overview. Even though I like new commands and more possibilities, having combined what can be combined makes it less confusing in my opinion.
We changed all commands that include a time argument to take timestrings instead of pure integers (and default to seconds if no unit for the time is given) to be consistent. Maybe we should also stay consistent here, even though like a 2m delay wouldn't make much sense, it would still be consistent over all commands then. Edit: And avoid a possible integer overflow

Kitzunu · 2023-06-27T17:39:19Z

PR Abandoned. If you want to continue work on this address the comment above. Open a new PR or reopen this

Core/Commands [Implement kickdelay command]

93722e5

Yehonal added CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Script labels Dec 17, 2022

hguy23 added 2 commits December 17, 2022 08:21

Core/Commands [Implement bandelay command]

935d248

Core/Commands [Fix comparison of unsigned expression < 0 is always fa…

c96f524

…lse]

Kitzunu requested changes Dec 17, 2022

View reviewed changes

data/sql/updates/pending_db_world/rev_1671258222610106000.sql Outdated Show resolved Hide resolved

src/server/scripts/Commands/cs_ban.cpp Outdated Show resolved Hide resolved

src/server/scripts/Commands/cs_ban.cpp Outdated Show resolved Hide resolved

hguy23 added 2 commits December 17, 2022 15:58

Core/Commands [Requested changes]

0a91ca1

Core/Commands [Missed compile errors]

2669434

hguy23 requested a review from Kitzunu December 17, 2022 15:15

Kitzunu reviewed Dec 17, 2022

View reviewed changes

acidmanifesto suggested changes Dec 17, 2022

View reviewed changes

data/sql/updates/pending_db_world/rev_1671258222610106000.sql Outdated Show resolved Hide resolved

src/server/scripts/Commands/cs_misc.cpp Outdated Show resolved Hide resolved

hguy23 added 2 commits December 18, 2022 10:04

Core/Commands [Requested changes]

10642a0

Core/Commands [Requested changes]

1a395ac

hguy23 requested review from Kitzunu and acidmanifesto and removed request for Kitzunu and acidmanifesto December 18, 2022 09:09

hguy23 added 3 commits December 18, 2022 10:35

Core/Commands [Requested changes]

27a93f7

Core/Commands [Requested changes]

52bb660

Core/Commands [Avoid possible crash when delay time is not presented]

978cc2f

hguy23 requested review from acidmanifesto and Kitzunu and removed request for Kitzunu and acidmanifesto December 18, 2022 20:02

Core/Commands [Requested changes]

6bb4ee5

hguy23 requested review from acidmanifesto and removed request for Kitzunu December 19, 2022 15:52

Kitzunu requested changes Dec 19, 2022

View reviewed changes

Core/Commands [Changed how world text is handled for delayed kick/ban]

d8161b0

Core/Commands [Requested changes]

hguy23 requested review from Kitzunu and removed request for acidmanifesto December 20, 2022 00:55

hguy23 added 2 commits December 20, 2022 04:23

Core/Commands [Crashfix]

ce1e0d3

Core/Commands [Crashfix]

54e5009

ghost added Waiting to be Tested Ready to be Reviewed labels Jan 21, 2023

acidmanifesto added the run-build Used to trigger the windows/mac/docker and matrix builds label Jan 27, 2023

acidmanifesto suggested changes Jan 27, 2023

View reviewed changes

ghost removed the Waiting to be Tested label Feb 5, 2023

Nyeriah added the Waiting to be Tested label Jun 27, 2023

Kitzunu added the PR Abandoned Original author stopped working on this PR. Feel free to take over. label Jun 27, 2023

Kitzunu closed this Jun 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core/Commands [Implement kickdelay command] #14250

Core/Commands [Implement kickdelay command] #14250

hguy23 commented Dec 17, 2022 •

edited

Loading

hguy23 commented Dec 17, 2022

Kitzunu left a comment

hguy23 commented Dec 18, 2022

acidmanifesto commented Dec 18, 2022

hguy23 commented Dec 19, 2022

55Honey commented Dec 19, 2022

hguy23 commented Dec 19, 2022

Kitzunu Dec 19, 2022

hguy23 Dec 19, 2022

Kitzunu Dec 22, 2022

hguy23 Dec 22, 2022

hguy23 Dec 22, 2022

Kitzunu Dec 22, 2022 •

edited

Loading

Kitzunu Dec 19, 2022

hguy23 Dec 19, 2022

Kitzunu Dec 22, 2022

hguy23 commented Dec 20, 2022

acidmanifesto commented Dec 20, 2022

hguy23 commented Dec 20, 2022 •

edited

Loading

55Honey commented Dec 20, 2022

hguy23 commented Dec 20, 2022

Kitzunu commented Dec 22, 2022

acidmanifesto commented Jan 27, 2023

acidmanifesto left a comment

ghost commented Feb 5, 2023 •

edited by ghost

Loading

Gozzim commented Feb 12, 2023 •

edited

Loading

Kitzunu commented Jun 27, 2023

Core/Commands [Implement kickdelay command] #14250

Core/Commands [Implement kickdelay command] #14250

Conversation

hguy23 commented Dec 17, 2022 • edited Loading

Changes Proposed:

Issues Addressed:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

How to Test AzerothCore PRs

hguy23 commented Dec 17, 2022

Kitzunu left a comment

Choose a reason for hiding this comment

hguy23 commented Dec 18, 2022

acidmanifesto commented Dec 18, 2022

hguy23 commented Dec 19, 2022

55Honey commented Dec 19, 2022

hguy23 commented Dec 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kitzunu Dec 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hguy23 commented Dec 20, 2022

acidmanifesto commented Dec 20, 2022

hguy23 commented Dec 20, 2022 • edited Loading

55Honey commented Dec 20, 2022

hguy23 commented Dec 20, 2022

Kitzunu commented Dec 22, 2022

acidmanifesto commented Jan 27, 2023

acidmanifesto left a comment

Choose a reason for hiding this comment

ghost commented Feb 5, 2023 • edited by ghost Loading

Gozzim commented Feb 12, 2023 • edited Loading

Kitzunu commented Jun 27, 2023

hguy23 commented Dec 17, 2022 •

edited

Loading

Kitzunu Dec 22, 2022 •

edited

Loading

hguy23 commented Dec 20, 2022 •

edited

Loading

ghost commented Feb 5, 2023 •

edited by ghost

Loading

Gozzim commented Feb 12, 2023 •

edited

Loading