Goregek's Endurance also heals the player when the player does damage

[steenburgh]

CURRENT BEHAVIOUR:

When the player has Goregek as a pet for the quest line that starts with "The Ape Hunter's Slave" both the player and the pet receive a buff: Goregek's Endurance. When the player does damage, the player is healed. When Goregek does damage, Goregek is healed.

A similar problem happens with Zepik's Fervor and Dajik's Balance. With Zepik's Fervor, the player receives the buff when the player does damage, and with Dajik's Balance, the player received mana when the player does damage.

EXPECTED BLIZZLIKE BEHAVIOUR:

From the spell description:

Sometimes heals Goregek for 272 to 428 health when damaging an enemy.

What this means to me is:

• When Goregek does damage, Goregek is healed
• When the player does damage, the player is not healed

Here's a YouTube video that shows the player not getting healed. However, do note that both the player, and Goregek have the buff.

STEPS TO REPRODUCE THE PROBLEM:

As a GM (easier)

1. Give yourself Goregek's Shackles: .additem 38619
2. Go to Sholozar Basin. .go xyz 5338.440430 4685.808105 -137.431488 571
3. Use the shackles to summon Goregek.
4. Hit a mob with a spell
5. Watch the combat log, and/or the floating combat text. You'll notice that you're healed every time you do damage, and so is Goregek

As a player:

1. Accept the quest, "The Ape Hunter's Slave" from Elder Harkek. You should receive an item, Goregek's Shackles
2. Use Goregek's Shackles to summon Goregek
3. Find a mob and hit it with a spell
4. Watch the combat log, and/or the floating combat text. You'll notice that you're healed every time you do damage, and so is Goregek

EXTRA NOTES:

I spent some time digging through the spell data, and it looks like the 3 spells affected by this are the only spells in game with both an "APPLY_AREA_AURA_PET" spell effect, and procs, For all 3 of these spells, when they proc, they apply an aura named "SPELL_AURA_PROC_TRIGGER_SPELL" with a target of "TARGET_UNIT_CASTER". The triggered spell is the healing/mana restoring/buff that the pet is supposed to receive. I think the problem here is how Azeroth Core is interpreting this data.

I have two theories, but take these with a grain of salt as my knowledge of WoW spell data is severely limited.

1. Maybe "TARGET_UNIT_CASTER" is supposed to refer to the caster of the pet aura, not the *caster of the spell that triggered the aura effect. If this was the only problem, however, expected behavior would be that the player's attacks heal the pet, which I don't believe is the intent here. I considered searching for non-pet auras in game that are supposed to behave similarly, but could not find any so I'm not sure what the intended behavior is here.
2. Maybe an "APPLY_AREA_AURA_PET" spell effect with procs is supposed to only apply to proc off of pet actions, but if this is the case, that would make it harder for blizzard to add pet auras that buff the player when the player performs an action. I tried searching for non-pet auras that proc spell effects, and couldn't find any similar enough to make a judgement call here.

AC HASH/COMMIT:

27ed629

OPERATING SYSTEM:

Windows 10.0.19041

MODULES:

• mod-ah-bot (custom build from [WIP] Add simple mode steenburgh/mod-ah-bot#1)
• mod-autobalance
• mod-individual-xp

OTHER CUSTOMIZATIONS:

• I have applied the Brewfest Start Time fix from fix(DB/Event): Brewfest starttime #3487

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[avarishd]

Can confirm, player gets affected by the 3 spells, also spells are without a cooldown.

(from wowhead)

DELETE FROM `spell_proc_event` WHERE `entry` IN (54178,54176,52734);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `procPhase`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES
(52734, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3000),
(54176, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10000),
(54178, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3000);