-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Core/Spell): Apply AURA_STATE_FAERIE_FIRE to Faerie Fire #5319
Conversation
Tested |
@ErnestoGonzalezC thanks for your feedback, but can you please be more descriptive about what you tested? also, please note:
|
@FrancescoBorzi Basically I followed @Kitzunu instructions. I used the aura (16498) on me and then I tried to use invisible (failed) then I tried to use (Invisibility Potion = 9172) and I can't make myself invisible therefore the PR is effective :) |
@ErnestoGonzalezC as the PR changes are quite "generic" (i.e. targetting a file that manges many things, I would say it's better to also double-check those in cases like this |
@FrancescoBorzi I've been testing this PR for several days and it doesn't seem to cause any kind of bug |
thanks @ErnestoGonzalezC for your feedback! |
Changes Proposed:
Issues Addressed:
Tests Performed:
How to Test the Changes:
Target Branch(es):
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.