Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Core/Spell): Apply AURA_STATE_FAERIE_FIRE to Faerie Fire #5319

Merged
merged 4 commits into from
Apr 26, 2021

Conversation

Kitzunu
Copy link
Member

@Kitzunu Kitzunu commented Apr 16, 2021

Changes Proposed:

  • Apply AURA_STATE_FAERIE_FIRE to Faerie Fire to disallow going stealth or invisible

Issues Addressed:

Tests Performed:

  • Builds
  • Tested in-game

How to Test the Changes:

  1. .aura 16498
  2. Try to use stealth
  3. .add 9172
  4. Try and use the potion

Target Branch(es):

  • Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@ernesto-glz
Copy link
Contributor

Tested

@FrancescoBorzi
Copy link
Member

@ErnestoGonzalezC thanks for your feedback, but can you please be more descriptive about what you tested?

also, please note:

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@ernesto-glz
Copy link
Contributor

@FrancescoBorzi Basically I followed @Kitzunu instructions. I used the aura (16498) on me and then I tried to use invisible (failed) then I tried to use (Invisibility Potion = 9172) and I can't make myself invisible therefore the PR is effective :)

@FrancescoBorzi
Copy link
Member

@ErnestoGonzalezC as the PR changes are quite "generic" (i.e. targetting a file that manges many things, src/server/game/Spells/SpellInfo.cpp) and as other spells are involved:

image

I would say it's better to also double-check those in cases like this

@ernesto-glz
Copy link
Contributor

@FrancescoBorzi I've been testing this PR for several days and it doesn't seem to cause any kind of bug

@FrancescoBorzi
Copy link
Member

thanks @ErnestoGonzalezC for your feedback!

@Kitzunu Kitzunu merged commit eac6cdd into azerothcore:master Apr 26, 2021
@Kitzunu Kitzunu deleted the fix-faeriefire branch April 26, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spell] Winterfall Pathfinder's Faerie Fire does not prevent stealthing
3 participants