Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB): Red Whelp Skinning loot #11944

Closed
wants to merge 1 commit into from
Closed

fix(DB): Red Whelp Skinning loot #11944

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 3, 2022

Changes Proposed:

  • Removed wrong creatures from Red Whelp's skinning loot table
  • Updated comments on respective items

Issues Addressed:

SOURCE:

wowwiki and issue debate

Tests Performed:

  • Not tested.

How to Test the Changes:

  1. Try to skin the entries mention on the issue. Only the 3 whelps should be skinnable.

Known Issues and TODO List:

None

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

- Removed wrong creatures from Red Whelp's skinning loot table
- Updated comments on respective items
@Yehonal Yehonal added the DB related to the SQL database label Jun 3, 2022
@ghost ghost closed this Jun 6, 2022
@ghost ghost deleted the loot-fix branch June 6, 2022 18:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database Ready to be Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low level creatures skinnable and giving incorrect skinning loot
2 participants