feat: add types from definitely typed #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Ping me when that package is ready. |
Now type definitions will automatically be installed along with the package.
|
Type are ready, published and I'm happy to proceed if you're happy 👍 |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 157 157
Branches 37 37
=========================================
Hits 157 157 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adding type definitions to the project via Definitely Typed DefinitelyTyped/DefinitelyTyped#44510.
Now type definitions will automatically be installed along with the package.
Why:
Provide better typescript support.
How:
It adds the types dependency which is then automatically available to typescript users.