Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanos chart support for newer version of Thanos #1104

Closed
alexanderccc opened this issue Jul 7, 2020 · 2 comments · Fixed by #1105
Closed

Thanos chart support for newer version of Thanos #1104

alexanderccc opened this issue Jul 7, 2020 · 2 comments · Fixed by #1105

Comments

@alexanderccc
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not really, if trying to use thanos v13 image, thanos bucket would not start because of a missing argument

Describe the solution you'd like to see
adding - "tools" as the first argument in the deployment of thanos bucket

Describe alternatives you've considered
none

Additional context

The helm chart seems to work fine with the latest version of thanos, the only issue is with thanos bucket deployment which is missing an argument. It seems that giving it as an extra argument inside the helm chart is not working. This should be an easy change, just adding tools to the arguments hardcoded in the deployment of thanos.

@wiardvanrij
Copy link
Contributor

Relates to this PR: thanos-io/thanos#2513

Tools: Moved thanos bucket commands to thanos tools bucket, also
moved thanos check rules to thanos tools rules-check. thanos tools rules-check also takes rules by --rules repeated flag not argument anymore.

@alexanderccc
Copy link
Contributor Author

Created PR #1105 that should fix this

@ahma ahma closed this as completed in #1105 Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants