Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prebuild to avoid external installing in vscode #62

Closed
mads-hartmann opened this issue Jul 17, 2018 · 8 comments · Fixed by tree-sitter/tree-sitter-bash#20
Closed
Assignees
Labels
enhancement New feature or request

Comments

@mads-hartmann
Copy link
Collaborator

Investigate if we can use prebuild and prebuild-install and then have the bash-language-server as a direct dependency on the vscode extension. The goal is to avoid having to install the server separately for vscode.

@mads-hartmann mads-hartmann added the enhancement New feature or request label Jul 17, 2018
@skovhus
Copy link
Collaborator

skovhus commented Jul 17, 2018

This would be great! 👍

I guess this depends on tree-sitter/node-tree-sitter#19 by @wingrunr21

@mads-hartmann
Copy link
Collaborator Author

@skovhus I'm not entirely sure - I don't fully grasp the build process of native node modules to be honest. I think we might be able to use prebuild to expose an already natively compiled version of our package and its dependencies (so we would be duplicating some of the work happening in that PR). We could also just wait and see if it just works once that PR is merged ;)

@wingrunr21
Copy link

@mads-hartmann it should "just work" (I hope) once the PR is merged. I'm using tree-sitter in vscode-ruby to build a new language server there.

@mads-hartmann
Copy link
Collaborator Author

@wingrunr21 Awesome - that's going to drastically reduce the number of issues we get I hope 👏

@wingrunr21
Copy link

@mads-hartmann The PR against node-tree-sitter is merged. I pushed PRs against tree-sitter-ruby and tree-sitter-bash today to add support to them as well.

@mads-hartmann
Copy link
Collaborator Author

@wingrunr21 Beautiful. Can't wait to try it out 👏

@maxbrunsfeld
Copy link

@mads-hartmann The pre-built binaries are up. Users should be able to install v0.13.1 of both modules without a compiler toolchain.

@mads-hartmann
Copy link
Collaborator Author

Fixed in bash-language-server v. 1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants