New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merger.Merge should return an error #1929

Open

ashi009 opened this issue Sep 20, 2024 · 0 comments

Contributor

ashi009 commented Sep 20, 2024

What version of gazelle are you using?

0.38.0

What version of rules_go are you using?

N/A

What version of Bazel are you using?

7.1.0

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

N/A

What did you do?

When implementing Merger, there is no way to return merge errors.

However, the mergeAttrValues function supports error handling.

bazel-gazelle/rule/merge.go

Line 100 in 571d953

func mergeAttrValues(srcAttr, dstAttr *attrValue) (bzl.Expr, error) {

It would be nice to return an error along the merged expr.

What did you expect to see?

What did you see instead?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment