Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.35] Breaks testonly oci_images #369

Closed
hanikesn opened this issue Sep 20, 2023 · 1 comment
Closed

[1.35] Breaks testonly oci_images #369

hanikesn opened this issue Sep 20, 2023 · 1 comment

Comments

@hanikesn
Copy link

After upgrading from 1.31 to 1.35 our oci_images marked with testonly stopped working:

ERROR: /__w/BUILD:31:30: in directory_path rule //X:X-e2e-tests_image_index_json: non-test target '//X:X-e2e-tests_image_index_json' depends on testonly target '//X:X-e2e-tests_image' and doesn't have testonly attribute set

I suspect #346 to introduce the breaking change.
@reltuk reltuk mentioned this issue Sep 20, 2023
Merged
@thesayyn
Copy link
Collaborator

This is fixed by #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanikesn @thesayyn