-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android_sdk_repository isn't compatible with Bzlmod #144
Comments
this is mostly fixed by #147, for the bind uses we'll have to change bazel I believe |
For avoiding bind usages, you can check https://bazel.build/external/migration#bind-targets, my guess is no Bazel change is required. |
Native Android rules depend on We should be able to remove these in the Starlark rules for the most part. |
I believe even before starlarkfying the android build rules, we can just replace those labels to directly pointing to |
The actual labels are in |
FWIW I am close to fixing this (finally!). There are two changes pending review internally, after which a follow-up CL will clean up all the binds. There will also be a small bazelrc change necessary to point the SDK away from bazel's implicit definition: |
Very exciting to hear that, thanks for your hard work! Do I understand correctly that if we want to remove all the binds from Bazel's WORKSPACE.bzlmod file, we'll have to build Bazel with Bazel@HEAD? |
For Bazel itself, we'll delete the android_sdk_repository rule entirely closer to the Bazel 8 release, and when that happens, we can delete the binds too. |
The current Starlark implementation relies on native functions like bind and register_toolchains which are not supported in the Bzlmod
MODULE.bazel
file.The text was updated successfully, but these errors were encountered: