Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Results on Windows #26

Closed
maschad opened this issue May 22, 2023 · 3 comments
Closed

Inconsistent Results on Windows #26

maschad opened this issue May 22, 2023 · 3 comments

Comments

@maschad
Copy link

maschad commented May 22, 2023

Running this on a Windows OS will result in the compiling not finding any Typescript snippets. I suspect this may be because the Snippet Compiler uses path.basename which will lead to inconsistent results on a Windows vs Posix. If the intention is to work with POSIX file paths on any operating system, it may be best to use path.posix
@maschad maschad mentioned this issue May 22, 2023
Merged
@paulbrimicombe
Copy link
Collaborator

Ah. Thanks very much for this @maschad this is good to know! I'll see if I can get a fix in for this soon.

@paulbrimicombe paulbrimicombe mentioned this issue Jun 16, 2023
Merged
@paulbrimicombe
Copy link
Collaborator

Sorry I've taken so long to get to this. There were a number of problems (path.basename not being one of them). I've published version 2.4.1 which should now work on Windows. Let me know if there are any other problems!

@maschad
Copy link
Author

maschad commented Jun 16, 2023

Awesome! I'll upgrade and give it a try! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maschad @paulbrimicombe