Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code samples should be great #610

Closed
franck34 opened this issue May 4, 2024 · 4 comments
Closed

Some code samples should be great #610

franck34 opened this issue May 4, 2024 · 4 comments

Comments

@franck34
Copy link
Contributor

franck34 commented May 4, 2024

Hi !

Thank for this great job.

The doc is very technical : it's hard to find things before going deeper

Wondering if you can add some code sample, i.e

  • search for an epic (get the epic code)
  • subscribe to ticks of an epic
  • get history candles of an epic

I think, in a first time, that most people want to do.

Cheers !

@franck34 franck34 changed the title some sample codes should be great some code samples should be great May 4, 2024
@franck34
Copy link
Contributor Author

franck34 commented May 4, 2024

Let me PR.

@franck34
Copy link
Contributor Author

franck34 commented May 4, 2024

@bennycode btw, your code is really really clean man, congrats !

@franck34 franck34 changed the title some code samples should be great Some code samples should be great May 8, 2024
@franck34
Copy link
Contributor Author

franck34 commented May 8, 2024

See PR #614

@bennycode
Copy link
Owner

Thanks for your PR! The README is updated now. You can also find many code examples here: https://github.com/bennycode/ig-trading-api/tree/main/src/demo

Best,
Benny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants