Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight delay on render #2

Closed
bradjabel opened this issue Jul 17, 2016 · 7 comments
Closed

Slight delay on render #2

bradjabel opened this issue Jul 17, 2016 · 7 comments

Comments

@bradjabel
Copy link

Awesome job on this :D Although, there seems to be a 0.5-1 second delay before the spinner actually shows up. I noticed this on the docs site. Is this due to a default fade in? If so, it would be nice to determine the duration of fade-in, or no fade in at all.

@bentatum
Copy link
Owner

bentatum commented Jul 19, 2016

Thanks for pointing this out @bradabelgit. Every spinner has a fadeIn property. Setting it to false will remove the fade effect.

@bradjabel
Copy link
Author

@bentatum Derp on my part, thanks so much, it's working great!

@bentatum
Copy link
Owner

@bradabelgit no, it's totally my fault. it's an undocumented behavior. I'm going to keep this open until I'm able to update docs. thanks.

@bentatum bentatum reopened this Jul 20, 2016
@bentatum bentatum mentioned this issue Jul 20, 2016
@bradjabel
Copy link
Author

Thanks again! Also, would it be possible to pass in the fade-in duration? That would be awesome!

@bentatum
Copy link
Owner

v2.0.0-3

I decided to deprecate fadeIn. Since this uses react-fade, you can simply pass your react-fade params to fade.

Setting duration:

<ChasingDots fade={{ duration: 3 }} />

Removing fade:

<ThreeBounce fade={false} />

@bradjabel
Copy link
Author

@bentatum Perfect, thanks!

@bentatum
Copy link
Owner

I wanted to give everyone a heads up that as of 2.0.0-4, react-fade is no longer a part of this library. If you liked or need the fade effect you can achieve this using a module like react-fade. Example below:

import { default as React } from 'react'
import { default as Fade } from 'react-fade'
import { Circle } from 'better-react-spinkit'

const Spinner = () =>
  <Fade>
    <Circle />
  </Fade>

export default Spinner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants