Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write release notes for PR #12889: Implement GPU frustum culling. #1307

Closed
alice-i-cecile opened this issue Jun 3, 2024 · 2 comments · Fixed by #1439
Closed

Write release notes for PR #12889: Implement GPU frustum culling. #1307

alice-i-cecile opened this issue Jun 3, 2024 · 2 comments · Fixed by #1439

Comments

@alice-i-cecile
Copy link
Member

bevyengine/bevy#12889 needs release notes for the upcoming Bevy release!

Please reply below if you'd like to write these notes.
While the author(s) of the PR often have the context, knowledge and motivation to draft the release notes for their feature, anyone can contribute release notes!


Release notes should:

  1. Clearly motivate the change.
  2. Be written in a way that is understandable by the average Bevy user: some programming background and a general understanding of games.
  3. Show off the coolest features of the PR. Screenshots are awesome, but elegant APIs are also welcome!
  4. If this was a perf-centric PR, quantify the performance improvements. Graphs and statistics work well for this.

We can help you revise the release notes: a rough draft alone is incredibly useful :)
Your expertise is invaluable for contextualizing the changes; we'll work with you to bring the technical writing up to par.

To submit your release notes, modify ..\release-content\0.14\release-notes\12889_Implement_GPU_frustum_culling.md and submit a PR.
In that PR, please mention this issue with the Fixes #ISSUE_NUMBER keyphrase so it gets closed automatically.

@jgayfer
Copy link
Contributor

jgayfer commented Jun 20, 2024

Took a stab at this in #1439.

I need a hand on motivating the change, but (I think) the bones are there.

@alice-i-cecile alice-i-cecile added S-Needs-Review and removed S-Ready-For-Implementation The core questions are answered: just add code labels Jun 20, 2024
@zhaop
Copy link
Contributor

zhaop commented Jun 24, 2024

I suspect this is the wrong place to write this (and it looks like I'm late as it's already merged), but I'm new here and wasn't sure where this is supposed to go :)

I'm upgrading the transform-gizmo crate to 0.14.0-rc and noticed that Bevy #12889 changed the dynamic_offset: Option<NonMaxU32> field to extra_index: PhaseItemExtraIndex for a number of structs:

AlphaMask3d, AlphaMask3dDeferred, AlphaMask3dPrepass, Opaque2d, Opaque3dDeferred, Opaque3dPrepass, Shadow, Transmissive3d, Transparent2d, Transparent3d, TransparentUi

This seems like a breaking change (see e.g. bevy_ecs_tilemap's change) so it's probably a good idea to have this in the migration notes somewhere? As a draft suggestion:

The dynamic_offset: Option<NonMaxU32> field for phase items is now extra_index: PhaseItemExtraIndex, which wraps a u32. Instead of None, use PhaseItemExtraIndex::NONE. This change affects AlphaMask3d, AlphaMask3dDeferred, AlphaMask3dPrepass, Opaque2d, Opaque3dDeferred, Opaque3dPrepass, Shadow, Transmissive3d, Transparent2d, Transparent3d, and TransparentUi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants