diff --git a/crates/bevy_app/src/app.rs b/crates/bevy_app/src/app.rs index 5bbb9b5676abd..3978226597059 100644 --- a/crates/bevy_app/src/app.rs +++ b/crates/bevy_app/src/app.rs @@ -839,10 +839,7 @@ impl App { #[cfg(feature = "bevy_reflect")] pub fn register_type(&mut self) -> &mut Self { { - let registry = self - .world - .get_resource_mut::() - .unwrap(); + let registry = self.world.resource_mut::(); registry.write().register::(); } self diff --git a/crates/bevy_asset/src/asset_server.rs b/crates/bevy_asset/src/asset_server.rs index c1656368b5818..c7159f146d402 100644 --- a/crates/bevy_asset/src/asset_server.rs +++ b/crates/bevy_asset/src/asset_server.rs @@ -794,24 +794,18 @@ mod test { app.add_system(update_asset_storage_system::.after(FreeUnusedAssets)); fn load_asset(path: AssetPath, world: &World) -> HandleUntyped { - let asset_server = world.get_resource::().unwrap(); + let asset_server = world.resource::(); let id = futures_lite::future::block_on(asset_server.load_async(path.clone(), true)) .unwrap(); asset_server.get_handle_untyped(id) } fn get_asset(id: impl Into, world: &World) -> Option<&PngAsset> { - world - .get_resource::>() - .unwrap() - .get(id.into()) + world.resource::>().get(id.into()) } fn get_load_state(id: impl Into, world: &World) -> LoadState { - world - .get_resource::() - .unwrap() - .get_load_state(id.into()) + world.resource::().get_load_state(id.into()) } // --- diff --git a/crates/bevy_asset/src/assets.rs b/crates/bevy_asset/src/assets.rs index a848132363a2d..5848ca654d7b3 100644 --- a/crates/bevy_asset/src/assets.rs +++ b/crates/bevy_asset/src/assets.rs @@ -287,7 +287,7 @@ impl AddAsset for App { return self; } let assets = { - let asset_server = self.world.get_resource::().unwrap(); + let asset_server = self.world.resource::(); asset_server.register_asset_type::() }; @@ -307,8 +307,7 @@ impl AddAsset for App { self.add_system(crate::debug_asset_server::sync_debug_assets::); let mut app = self .world - .get_non_send_resource_mut::() - .unwrap(); + .non_send_resource_mut::(); app.add_asset::() .init_resource::>(); } @@ -331,8 +330,7 @@ impl AddAsset for App { { let mut app = self .world - .get_non_send_resource_mut::() - .unwrap(); + .non_send_resource_mut::(); app.init_asset_loader::(); } self @@ -342,10 +340,7 @@ impl AddAsset for App { where T: AssetLoader, { - self.world - .get_resource_mut::() - .expect("AssetServer does not exist. Consider adding it as a resource.") - .add_loader(loader); + self.world.resource_mut::().add_loader(loader); self } } @@ -357,8 +352,7 @@ macro_rules! load_internal_asset { { let mut debug_app = $app .world - .get_non_send_resource_mut::() - .unwrap(); + .non_send_resource_mut::(); bevy_asset::debug_asset_server::register_handle_with_loader( $loader, &mut debug_app, @@ -367,10 +361,7 @@ macro_rules! load_internal_asset { $path_str, ); } - let mut assets = $app - .world - .get_resource_mut::>() - .unwrap(); + let mut assets = $app.world.resource_mut::>(); assets.set_untracked($handle, ($loader)(include_str!($path_str))); }}; } @@ -379,10 +370,7 @@ macro_rules! load_internal_asset { #[macro_export] macro_rules! load_internal_asset { ($app: ident, $handle: ident, $path_str: expr, $loader: expr) => {{ - let mut assets = $app - .world - .get_resource_mut::>() - .unwrap(); + let mut assets = $app.world.resource_mut::>(); assets.set_untracked($handle, ($loader)(include_str!($path_str))); }}; } @@ -402,10 +390,10 @@ mod tests { app.add_plugin(bevy_core::CorePlugin) .add_plugin(crate::AssetPlugin); app.add_asset::(); - let mut assets_before = app.world.get_resource_mut::>().unwrap(); + let mut assets_before = app.world.resource_mut::>(); let handle = assets_before.add(MyAsset); app.add_asset::(); // Ensure this doesn't overwrite the Asset - let assets_after = app.world.get_resource_mut::>().unwrap(); + let assets_after = app.world.resource_mut::>(); assert!(assets_after.get(handle).is_some()); } } diff --git a/crates/bevy_asset/src/lib.rs b/crates/bevy_asset/src/lib.rs index 6e31a62ea6546..870f100d10306 100644 --- a/crates/bevy_asset/src/lib.rs +++ b/crates/bevy_asset/src/lib.rs @@ -81,13 +81,8 @@ pub fn create_platform_default_asset_io(app: &mut App) -> Box { impl Plugin for AssetPlugin { fn build(&self, app: &mut App) { - if app.world.get_resource::().is_none() { - let task_pool = app - .world - .get_resource::() - .expect("`IoTaskPool` resource not found.") - .0 - .clone(); + if !app.world.contains_resource::() { + let task_pool = app.world.resource::().0.clone(); let source = create_platform_default_asset_io(app); diff --git a/crates/bevy_core/src/time/fixed_timestep.rs b/crates/bevy_core/src/time/fixed_timestep.rs index fa39ced311997..d4469ec9b87fe 100644 --- a/crates/bevy_core/src/time/fixed_timestep.rs +++ b/crates/bevy_core/src/time/fixed_timestep.rs @@ -209,7 +209,7 @@ impl System for FixedTimestep { ))); self.internal_system.initialize(world); if let Some(ref label) = self.state.label { - let mut fixed_timesteps = world.get_resource_mut::().unwrap(); + let mut fixed_timesteps = world.resource_mut::(); fixed_timesteps.fixed_timesteps.insert( label.clone(), FixedTimestepState { @@ -257,25 +257,25 @@ mod test { // if time does not progress, the step does not run schedule.run(&mut world); schedule.run(&mut world); - assert_eq!(0, *world.get_resource::().unwrap()); + assert_eq!(0, *world.resource::()); assert_eq!(0., get_accumulator_deciseconds(&world)); // let's progress less than one step advance_time(&mut world, instance, 0.4); schedule.run(&mut world); - assert_eq!(0, *world.get_resource::().unwrap()); + assert_eq!(0, *world.resource::()); assert_eq!(4., get_accumulator_deciseconds(&world)); // finish the first step with 0.1s above the step length advance_time(&mut world, instance, 0.6); schedule.run(&mut world); - assert_eq!(1, *world.get_resource::().unwrap()); + assert_eq!(1, *world.resource::()); assert_eq!(1., get_accumulator_deciseconds(&world)); // runs multiple times if the delta is multiple step lengths advance_time(&mut world, instance, 1.7); schedule.run(&mut world); - assert_eq!(3, *world.get_resource::().unwrap()); + assert_eq!(3, *world.resource::()); assert_eq!(2., get_accumulator_deciseconds(&world)); } @@ -285,15 +285,13 @@ mod test { fn advance_time(world: &mut World, instance: Instant, seconds: f32) { world - .get_resource_mut::