Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

Throw better error message when redefining a property #24

Closed
Robdel12 opened this issue May 15, 2018 · 3 comments
Closed

Throw better error message when redefining a property #24

Robdel12 opened this issue May 15, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@Robdel12
Copy link
Contributor

It's not obvious that there are default properties on an interactor like isVisible. If you set a property on an interactor with the same key you'll get an error like:

Uncaught Error: cannot redefine existing property "isVisible"

In an ideal world we should throw an error saying something like "Interactor already has a property named isVisible, please choose a new name"

Or something that says that interactor provides this. I spent ~5 mins looking for a duplicate until I realized what was going on.

@Robdel12 Robdel12 added the enhancement New feature or request label May 15, 2018
@wwilsman
Copy link
Contributor

Can this be closed with the updated property name restrictions? Or should we still address the new "reserved property name" error?

@wwilsman
Copy link
Contributor

Going to assume this can be closed with the new error

@Robdel12
Copy link
Contributor Author

Yea that makes sense

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants