Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

Configure ES modules properly #6

Closed
Robdel12 opened this issue Apr 15, 2018 · 0 comments · Fixed by #11
Closed

Configure ES modules properly #6

Robdel12 opened this issue Apr 15, 2018 · 0 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@Robdel12
Copy link
Contributor

It is common in a webpack environment when using babel to not transform modules within the node_modules directory. Our package's "module" field points directly to the src files, which are typically compiled with @babel/preset-env. When babel is configured to not compile our packages within node_modules, bundles that use our packages can end up broken.

This can be seen in @bigtest/interaction tests by removing the (!?/@bigtest) regexp within the babel-loader exclude option in the karma.config.js file. This causes the package to fail to properly extend the convergence class and thereby causes every test to fail.

(moved from thefrontside/bigtest#55)

@Robdel12 Robdel12 added the bug Something isn't working label Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant