Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for remote volumes without CORS #355

Closed
2 of 3 tasks
mzur opened this issue Jun 23, 2021 · 1 comment
Closed
2 of 3 tasks

Drop support for remote volumes without CORS #355

mzur opened this issue Jun 23, 2021 · 1 comment

Comments

@mzur
Copy link
Member

mzur commented Jun 23, 2021

As mentioned in #351 support for remote volumes without CORS should be dropped in a future release to avoid issues with the display of images. We could do this in an iterative approach:

  • Show a prominent warning message for affected images.
  • Show a notice when new remote volumes are created.
  • Reject new remote volumes if CORS is not configured properly.

I don't think that we need to make the additional step and disable display of remote images without CORS entirely. The prominent warning message should make everyone aware of the issue.

@mzur
Copy link
Member Author

mzur commented Aug 3, 2021

I'll leave it at that and don't reject new volumes without proper CORS configuration. The warning message is enough. We won't drop support for these images either.

@mzur mzur closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant