Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CloneImagesOrVideos more efficient #944

Open
mzur opened this issue Oct 9, 2024 · 0 comments · May be fixed by #952
Open

Make CloneImagesOrVideos more efficient #944

mzur opened this issue Oct 9, 2024 · 0 comments · May be fixed by #952
Assignees

Comments

@mzur
Copy link
Member

mzur commented Oct 9, 2024

The CloneImagesOrVideos job calls ProcessNewVolumeFiles to generate thumbnails etc. for the new files of a volume. This can be problematic if the volume consists of many large videos or tiled images. If all of these images/videos are processed at the same time, worker hosts can be overwhelmed.

But the clone job can be made more efficient, as all the thumbnail etc data already exists. Instead of calling ProcessNewVolumeFiles, we should implement new jobs "CloneImageThumbnails" and "CloneVideoThumbnails" (or similar). Each of these jobs gets one old image/video and the respective new (cloned) image/video. The CloneImageThumbnails job then copies the image thumbnail of the old image to the location of the thumbnail of the new image. Also, if the old image is tiled, it copies all the tile data to the location of the new image. If either the thumbnail or tile data does not exist, the job calls ProcessNewImage. Similarly, CloneVideoThumbnails copies all the video thumbnails and the new video preview sprites. If any of these does not exist, it calls ProcessNewVideo (on the appropriate queue, see ProcessNewVolumeFiles).

@lehecht lehecht self-assigned this Oct 11, 2024
@lehecht lehecht linked a pull request Oct 17, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Medium Priority
Development

Successfully merging a pull request may close this issue.

2 participants