Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fd_cache_size configureable via env variable #130

Closed
andreasprlic opened this issue Jan 8, 2024 · 0 comments · Fixed by #131
Closed

Make fd_cache_size configureable via env variable #130

andreasprlic opened this issue Jan 8, 2024 · 0 comments · Fixed by #131
Assignees

Comments

@andreasprlic
Copy link
Contributor

andreasprlic commented Jan 8, 2024

Is your feature request related to a problem? Please describe.
With the most recent changes to address thread safety related issues, the performance of SeqRepo while running with the default fd_cache_size=0 has been greatly impacted. At the moment the fd_cache_size parameter needs to get passed as an argument when creating a new SeqRepo instance. That makes it somewhat difficult to change for libraries that already depend on SeqRepo.

Describe the solution you'd like
To make it easier to modify the fd_cache_size behavior it would be great to be able to modify this via an env variable. Something like SEQREPO_LRU_CACHE_MAXSIZE.

Additional context
Currently the default behavior has a 10x slower performance compared to seqrepo v. 0.6.4. That's somewhat problematic and perhaps the default should not be 0 for the cache size?

@kazmiekr kazmiekr self-assigned this Jan 8, 2024
@kazmiekr kazmiekr linked a pull request Jan 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants