Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoverPubkey not work with ECC_CURVE_SM2_STANDARD #4

Open
pip1998 opened this issue Feb 18, 2020 · 1 comment
Open

RecoverPubkey not work with ECC_CURVE_SM2_STANDARD #4

pip1998 opened this issue Feb 18, 2020 · 1 comment

Comments

@pip1998
Copy link

pip1998 commented Feb 18, 2020

cannot work with curve ECC_CURVE_SM2_STANDARD

func RecoverPubkey(sig []byte, msg []byte, typeChoose uint32) ([]byte, uint16) {

Recurrent

  1. run the rest in PR: test: RecoverPubkey #3
@heshuchao
Copy link
Contributor

Sorry for taking so long to reply you, The SM2 public key recovery part is not tested because it is not used in our system. And the current process follows ecdsa's standard, which is clearly wrong.

I'll study whether SM2 supported public key recovery and fix the bug(or delete it if not support),
Thanks for let me know and sorry for the trouble this has caused you.

抱歉这么晚才回复你, SM2的公钥恢复这一部分因为在我们系统里面一直没有用到,所以没有测试。目前的代码是和ECDSA的secp256k1共享一个流程, 所以明显是错误的。

最近我会研究一下SM2的签名流程是否支持此类公钥恢复, 如果支持会尽快修复bug,不支持会删除这部分代码。

抱歉这部分代码给你造成了困扰。

感谢告知!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants